fix: prune left-elsewhere rooms from sliding sync sidebar cache before hydration#1102
Open
eleboucher wants to merge 1 commit into
Open
fix: prune left-elsewhere rooms from sliding sync sidebar cache before hydration#1102eleboucher wants to merge 1 commit into
eleboucher wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
With sliding sync, the sidebar briefly showed rooms/spaces you'd left on another device, then removed them once reconciliation ran. This fetches the joined-rooms set before hydration and prunes stale rooms from the cache first, so the sidebar renders once at the correct count. Invites are kept; if the request is slow (2s) or offline, it falls back to the old behaviour.
Fixes #
Type of change
Checklist:
AI disclosure: