Skip to content

fix(tauri): stream android media uploads to fix OOM and show progress and diverse input improvement#1154

Merged
7w1 merged 3 commits into
SableClient:devfrom
eleboucher:fix/android-media-upload-mobile-composer
Jul 20, 2026
Merged

fix(tauri): stream android media uploads to fix OOM and show progress and diverse input improvement#1154
7w1 merged 3 commits into
SableClient:devfrom
eleboucher:fix/android-media-upload-mobile-composer

Conversation

@eleboucher

@eleboucher eleboucher commented Jul 20, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Fixes #

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

AI disclosure:

  • Partially AI assisted (clarify which code was AI assisted and briefly explain what it does).
  • Fully AI generated (explain what all the generated code does in moderate detail).

@eleboucher
eleboucher requested review from 7w1 and hazre as code owners July 20, 2026 08:21
@eleboucher
eleboucher force-pushed the fix/android-media-upload-mobile-composer branch from cd05e96 to 2467a78 Compare July 20, 2026 09:35
7w1
7w1 reviewed Jul 20, 2026
View reviewed changes
Comment thread src-tauri/src/network/native_upload.rs
@eleboucher
eleboucher force-pushed the fix/android-media-upload-mobile-composer branch from 2467a78 to 8bef45b Compare July 20, 2026 18:14
eleboucher added a commit to eleboucher/Sable that referenced this pull request Jul 20, 2026
@eleboucher
fix(tauri): purge orphaned upload temp files on startup
02036cd 
Addresses 7w1's review on SableClient#1154: if the app is killed or crashes
mid-upload, the per-request temp file under app_cache_dir/native-uploads
was only removed on the success/abort paths, so it leaked. Wipe the
whole subdir in the Tauri setup hook before any upload can start.
@eleboucher
eleboucher force-pushed the fix/android-media-upload-mobile-composer branch from 02036cd to 7e266bc Compare July 20, 2026 19:30
@7w1
7w1 added this pull request to the merge queue Jul 20, 2026
Merged via the queue into SableClient:dev with commit 1041ad3 Jul 20, 2026
14 checks passed
@sable-actions sable-actions Bot mentioned this pull request Jul 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@7w1 7w1 7w1 approved these changes
@hazre hazre Awaiting requested review from hazre hazre is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eleboucher @7w1