feat(presence): presence badges, auto-idle, and Discord-style status picker by Just-Insane · Pull Request #689 · SableClient/Sable

Just-Insane · 2026-04-15T15:06:02Z

Description

Combined presence PR — replaces #608 and #672 with a single branch rebased onto upstream/dev to resolve merge conflicts cleanly.

Presence sidebar badges (from #608)

Adds live presence badges (online / idle / DND / offline) to the compact sidebar DM icon rail (DirectDMsList) and the account switcher avatar (AccountSwitcherTab).
AvatarPresence and PresenceBadge components for consistent badge rendering.
Fixes sliding-sync presence: MSC4186 doesn't deliver m.presence events, so useUserPresence now falls back to GET /_matrix/client/v3/presence/{userId}/status to bootstrap presence state. If the server returns 404, the error is silently ignored.
ClientEvent.Event listener fallback for when the User object doesn't exist yet (sliding sync race condition).

Auto-idle & status picker (from #672)

Discord-style presence picker in the account switcher — Online, Idle, Do Not Disturb, Invisible.
presenceMode setting — persists the user's chosen status across sessions.
Auto-idle — after a configurable inactivity timeout (default 5 min), presence is automatically set to Idle. Activity (mouse move, keydown, touchstart) resets the timer and restores the previous status.
presenceAutoIdleTimeoutMs client config option to customize or disable (0) the auto-idle timer.
Skip empty userId presence fetch to prevent 400 errors during initial load race conditions.
Unit tests covering useUserPresence hook including the auto-idle timer and status transitions.

DND mode

Option	Badge	Matrix broadcast
Online	🟢 green dot	`presence: online`
Idle	🟡 yellow dot	`presence: unavailable`
Do Not Disturb	🔴 red dot	`presence: online`, `status_msg: dnd`
Invisible	(none)	`presence: offline`

Supersedes #608 and #672.

Type of change

New feature (non-breaking change which adds functionality)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my code
New and existing unit tests pass locally with my changes

Copilot

Pull request overview

Adds end-to-end presence UX (badges + status picker + auto-idle) and improves app visibility event plumbing, including sliding-sync presence bootstrapping behavior.

Changes:

Add presence badges to the compact DM rail and account switcher avatar, plus a Discord-style status picker.
Implement auto-idle with configurable timeout and introduce a presence REST bootstrap for sliding-sync environments.
Refactor appEvents visibility handling and expand useAppVisibility session-sync/heartbeat logic.

Reviewed changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
src/app/utils/appEvents.ts	Replace single visibility handlers with multi-subscriber emit/on API.
src/app/state/settings.ts	Add `presenceMode` setting + ephemeral `presenceAutoIdledAtom` (also introduces `enableMessageBookmarks`).
src/app/pages/client/sidebar/DirectDMsList.tsx	Render presence badges on compact DM avatars using `useUserPresence`.
src/app/pages/client/sidebar/AccountSwitcherTab.tsx	Add own-presence badge + status picker UI that writes `presenceMode`.
src/app/pages/client/ClientNonUIFeatures.tsx	Drive actual presence broadcasting + auto-idle integration and SW visibility handling.
src/app/hooks/useUserPresence.ts	Add sliding-sync REST bootstrap + client-level fallback listener; update labels.
src/app/hooks/useUserPresence.test.tsx	New unit tests for `useUserPresence`.
src/app/hooks/usePresenceAutoIdle.ts	New hook implementing inactivity auto-idle + visibility/activity listeners.
src/app/hooks/usePresenceAutoIdle.test.tsx	New unit tests for auto-idle behavior and cleanup.
src/app/hooks/useClientConfig.ts	Add experiment/sessionSync config types + variant selection helper + presence timeout config.
src/app/hooks/useAppVisibility.ts	Rebuild visibility/focus handlers + optional SW session-sync heartbeat behavior.
src/app/features/settings/developer-tools/DevelopTools.tsx	Add “Rotate Encryption Sessions” developer tool action.
config.json	Add `presenceAutoIdleTimeoutMs` default (5 min).
.changeset/presence-sidebar-badges.md	Changeset entry for presence badges.
.changeset/presence-auto-idle.md	Changeset entry for auto-idle + status picker.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-15T15:13:58Z

+  removeListener: vi.fn(),
+};
+
+vi.mock('$hooks/useMatrixClient', () => ({


The test mocks '$hooks/useMatrixClient', but useUserPresence imports useMatrixClient via a relative path ('./useMatrixClient'). This mock won’t be applied, so the hook will use the real matrix client and these tests will fail or become integration tests unintentionally. Mock the correct module path (or change useUserPresence to import from the aliased path consistently).

Suggested change

vi.mock('$hooks/useMatrixClient', () => ({

vi.mock('./useMatrixClient', () => ({

Copilot · 2026-04-15T15:13:59Z

+    mx.setPresence({
+      presence: effectiveState,
+      status_msg: sendPresence && effectiveMode === 'dnd' ? 'dnd' : '',


mx.setPresence is always sending status_msg: '' when not in DND. That will clear any existing status message set by this app (Profile status editor) or other clients, potentially on every mount/state change. Consider omitting status_msg entirely unless you’re explicitly setting DND, and/or persisting/restoring the previous status message when toggling DND so user-defined status text isn’t lost.

Suggested change

mx.setPresence({

presence: effectiveState,

status_msg: sendPresence && effectiveMode === 'dnd' ? 'dnd' : '',

// Only send status_msg when explicitly broadcasting DND; otherwise omit it so we

// don't clear any existing user-defined status text from this or other clients.

mx.setPresence({

presence: effectiveState,

...(sendPresence && effectiveMode === 'dnd' ? { status_msg: 'dnd' } : {}),

Copilot · 2026-04-15T15:13:59Z

+      (p) => p && p.lastActiveTs !== 0 && p.presence === Presence.Online
+    );
+
+  let presenceBadge: ReactNode;
+  if (!isGroupDM && singleDMPresence && singleDMPresence.lastActiveTs !== 0) {


lastActiveTs is optional in UserPresence (REST fallback sets it to undefined when last_active_ago is absent), but this logic treats undefined !== 0 as “known”. That can cause presence badges to render even when we don’t actually have a timestamp/bootstrapped presence. Consider explicitly checking lastActiveTs != null && lastActiveTs !== 0, or gating on a dedicated “hasPresenceData” flag from the hook.

Suggested change

(p) => p && p.lastActiveTs !== 0 && p.presence === Presence.Online

);

let presenceBadge: ReactNode;

if (!isGroupDM && singleDMPresence && singleDMPresence.lastActiveTs !== 0) {

(p) =>

p &&

p.lastActiveTs != null &&

p.lastActiveTs !== 0 &&

p.presence === Presence.Online

);

let presenceBadge: ReactNode;

if (

!isGroupDM &&

singleDMPresence &&

singleDMPresence.lastActiveTs != null &&

singleDMPresence.lastActiveTs !== 0

) {

Copilot · 2026-04-15T15:13:59Z

+  // experimental
+  enableMessageBookmarks: boolean;
+


enableMessageBookmarks is introduced here (interface + defaults) but isn’t mentioned in the PR description and appears unrelated to presence. Consider removing it from this PR or splitting it into a dedicated changeset/PR so the scope stays focused and reviewable.

Copilot · 2026-04-15T15:14:00Z

+      // (including bridge bots). fire-and-forget per room.
+      encryptedRooms.forEach((room) => crypto.prepareToEncrypt(room));


crypto.prepareToEncrypt(room) is invoked fire-and-forget for each room. If it returns a Promise (or can throw), this can lead to unhandled rejections and makes failures invisible. Consider explicitly voiding and attaching a .catch(...) per call, or awaiting with controlled concurrency if you need to ensure key sharing is actually queued successfully.

Suggested change

// (including bridge bots). fire-and-forget per room.

encryptedRooms.forEach((room) => crypto.prepareToEncrypt(room));

// (including bridge bots). fire-and-forget per room, but surface failures.

encryptedRooms.forEach((room) => {

void Promise.resolve()

.then(() => crypto.prepareToEncrypt(room))

.catch((error) => {

console.error('Failed to prepare room encryption', room.roomId, error);

});

});

Copilot · 2026-04-15T15:14:00Z

+    // Sliding sync (Synapse MSC4186) has no presence extension — m.presence events are never
+    // delivered via sync. As a result, User.presence stays at the SDK default and
+    // getLastActiveTs() stays 0. Fall back to a direct REST fetch to bootstrap presence state.
+    // Guard against empty userId — callers that render a fixed number of hooks (e.g. group DM
+    // slots) pass '' for absent members; firing getPresence('') would be a malformed request.
+    if (userId && (!user || user.getLastActiveTs() === 0)) {
+      mx.getPresence(userId)
+        .then((resp) => {
+          if (cancelled) return;
+          setPresence({
+            presence: resp.presence as Presence,
+            status: resp.status_msg,
+            active: resp.currently_active ?? false,
+            lastActiveTs:
+              resp.last_active_ago != null ? Date.now() - resp.last_active_ago : undefined,
+          });


The REST bootstrap (mx.getPresence(userId)) will run for every hook instance where getLastActiveTs() === 0 (e.g. MSC4186 sliding-sync), and this hook is used in large lists (members list, room nav, etc.). That can easily become an N+1 flood of /presence/{userId}/status requests. Consider adding a shared in-memory cache + in-flight dedupe (and ideally a short TTL) so multiple components/users don’t trigger redundant requests.

Copilot · 2026-04-15T15:14:00Z

+        .catch(() => {
+          // Presence not available on this server (404 or not supported) — keep existing state.
+        });


The REST fallback swallows all errors. The PR description calls out ignoring 404 when presence isn’t enabled, but this also hides transient network/server errors (and makes debugging harder). Consider only suppressing known “not supported/not found” cases (e.g. MatrixError with httpStatus===404 / M_NOT_FOUND) and logging others at debug/warn level.

Copilot · 2026-04-15T15:14:01Z


  useEffect(() => {
-    if (!mx) return;
+    if (!phase2VisibleHeartbeat) return undefined;


The heartbeat effect runs whenever phase2VisibleHeartbeat is enabled, even if mx is currently undefined (ClientRoot calls useAppVisibility(mx) during initial load). That will schedule recurring timers and repeatedly call pushSessionNow('heartbeat'), which will always ‘skipped’ and can generate noisy logs / unnecessary work. Consider guarding the heartbeat loop on mx being defined (and/or only starting once session prerequisites exist).

Suggested change

if (!phase2VisibleHeartbeat) return undefined;

if (!phase2VisibleHeartbeat || !mx) return undefined;

Copilot · 2026-04-15T15:14:01Z

+  const [rotateState, rotateAllSessions] = useAsyncCallback<
+    { rotated: number; total: number },
+    Error,
+    []
+  >(
+    useCallback(async () => {
+      const crypto = mx.getCrypto();
+      if (!crypto) throw new Error('Crypto module not available');
+
+      const encryptedRooms = mx
+        .getRooms()
+        .filter(
+          (room) =>
+            room.getMyMembership() === KnownMembership.Join && mx.isRoomEncrypted(room.roomId)
+        );
+
+      await Promise.all(encryptedRooms.map((room) => crypto.forceDiscardSession(room.roomId)));
+      const rotated = encryptedRooms.length;
+
+      // Proactively start session creation + key sharing with all devices
+      // (including bridge bots). fire-and-forget per room.
+      encryptedRooms.forEach((room) => crypto.prepareToEncrypt(room));
+
+      return { rotated, total: encryptedRooms.length };
+    }, [mx])


This PR adds a new Developer Tools action to rotate Megolm sessions across all encrypted rooms, but this functionality isn’t mentioned in the PR description (which is focused on presence). Consider splitting this into a separate PR/changeset to keep scope aligned and reduce risk for the presence feature rollout.

Copilot · 2026-04-15T15:14:01Z

+                        // Clear auto-idle so the badge updates immediately on manual selection.
+                        setAutoIdled(false);
+                        // Re-enable presence broadcasting if the master toggle was off
+                        if (!sendPresence) setSendPresence(true);


Selecting a status updates settings but does not close the popout menu (setMenuAnchor(undefined)), unlike other menu actions (e.g. Add Account / Settings). If the intended UX is to close after selection, consider closing the menu in this handler for consistency.

Suggested change

if (!sendPresence) setSendPresence(true);

if (!sendPresence) setSendPresence(true);

setMenuAnchor(undefined);

…tab hidden

… members drawer - AccountSwitcherTab: wrap SidebarAvatar in AvatarPresence with current user's dot - DirectDMsList: add AvatarPresence badge on 1:1 DM icons using the DM user's presence - MembersDrawer: replace lastActiveTs !== 0 guard with presence !== Offline so online users show a dot

…e setting The feat/presence-auto-idle branch (PR SableClient#672) was replaced by feat/presence (PR SableClient#689) without porting the picker, presenceMode setting, DND mode, or usePresenceAutoIdle hook. Restore from the 29e4076 tip still in the local object store. - appEvents: refactor to multi-subscriber Set pattern (supports multiple listeners on onVisibilityChange/onVisibilityHidden) - settings: add presenceMode ('online'|'unavailable'|'dnd'|'offline'), default 'online'; add ephemeral presenceAutoIdledAtom - usePresenceAutoIdle: new hook — inactivity timer, activity reset, appEvents visibility integration, multi-device sync via User.presence - usePresenceAutoIdle.test.tsx: 10 unit tests covering all branches - ClientNonUIFeatures: PresenceFeature now uses presenceMode + autoIdled to broadcast the correct presence state; DND sends status_msg='dnd' - AccountSwitcherTab: own badge driven from presenceMode settings state (not SDK User.presence which MSC4186 servers never echo back); adds Status section to account menu with Online/Idle/DND/Invisible picker

Just-Insane requested review from 7w1 and hazre as code owners April 15, 2026 15:06

Copilot AI review requested due to automatic review settings April 15, 2026 15:06

Copilot started reviewing on behalf of Just-Insane April 15, 2026 15:06 View session

This was referenced Apr 15, 2026

feat(presence): auto-idle presence after inactivity with Discord-style status picker #672

Closed

feat(presence): add presence badges to the DM list and account switcher #608

Closed

Copilot AI reviewed Apr 15, 2026

View reviewed changes

Just-Insane marked this pull request as draft April 17, 2026 11:55

Just-Insane force-pushed the feat/presence branch from d82f8e4 to d3d3888 Compare May 3, 2026 01:25

Just-Insane temporarily deployed to production May 3, 2026 01:25 — with GitHub Actions Inactive

Just-Insane temporarily deployed to production May 5, 2026 12:24 — with GitHub Actions Inactive

Just-Insane temporarily deployed to production May 5, 2026 14:31 — with GitHub Actions Inactive

Just-Insane force-pushed the feat/presence branch from 1d06a65 to 2de2315 Compare May 11, 2026 01:08

Just-Insane temporarily deployed to production May 11, 2026 01:08 — with GitHub Actions Inactive

Just-Insane temporarily deployed to production May 11, 2026 12:56 — with GitHub Actions Inactive

Just-Insane added 4 commits May 13, 2026 10:08

feat: presence auto-idle — set unavailable after 5 min inactivity or …

4383cfd

…tab hidden

fix(presence): publish online on enable, update auto-idle description

9806073

feat(presence): configurable idle timeout setting

74ca3b4

Just-Insane force-pushed the feat/presence branch from b161a41 to 74ca3b4 Compare May 13, 2026 14:28

Just-Insane mentioned this pull request May 14, 2026

fix(presence): show presence dot in account switcher, DM sidebar, and members drawer #826

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(presence): presence badges, auto-idle, and Discord-style status picker#689

feat(presence): presence badges, auto-idle, and Discord-style status picker#689
Just-Insane wants to merge 5 commits into
SableClient:devfrom
Just-Insane:feat/presence

Just-Insane commented Apr 15, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Copilot AI Apr 15, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	vi.mock('$hooks/useMatrixClient', () => ({
	vi.mock('./useMatrixClient', () => ({

		// (including bridge bots). fire-and-forget per room.
		encryptedRooms.forEach((room) => crypto.prepareToEncrypt(room));

-      // (including bridge bots). fire-and-forget per room.
-      encryptedRooms.forEach((room) => crypto.prepareToEncrypt(room));
+      // (including bridge bots). fire-and-forget per room, but surface failures.
+      encryptedRooms.forEach((room) => {
+        void Promise.resolve()
+          .then(() => crypto.prepareToEncrypt(room))
+          .catch((error) => {
+            console.error('Failed to prepare room encryption', room.roomId, error);
+          });
+      });

	if (!phase2VisibleHeartbeat) return undefined;
	if (!phase2VisibleHeartbeat \|\| !mx) return undefined;

	if (!sendPresence) setSendPresence(true);
	if (!sendPresence) setSendPresence(true);
	setMenuAnchor(undefined);

Conversation

Just-Insane commented Apr 15, 2026

Description

Presence sidebar badges (from #608)

Auto-idle & status picker (from #672)

DND mode

Type of change

Checklist

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 15, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants