fix(timeline): restore isReady recovery on failed jump-to-event#812
Draft
Just-Insane wants to merge 2 commits into
Draft
fix(timeline): restore isReady recovery on failed jump-to-event#812Just-Insane wants to merge 2 commits into
Just-Insane wants to merge 2 commits into
Conversation
…nt jumps Add a short-lived jump scroll block (~350 ms) after scrollToIndex calls so intermediate scroll events from the animation don't prematurely flip atBottom and show the "Jump to Latest" button when the user is already at the intended location.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When navigating to an event via a notification,
useTimelineActionscallsfocusItemwhich setsisReady = falseto hide the timeline during the jump animation. If the jump fails (event not in timeline, Matrix SDK error, etc.)isReadywas never restored totrue, leaving the timeline permanently blank for that room session.Adds a
finallyclause that always callssetIsReady(true)after the jump attempt, regardless of success or failure.Type of change
Checklist:
AI disclosure:
The AI identified the missing
finallyrecovery clause in the jump-to-event flow. The fix is a singlefinally { setIsReady(true) }block — I understand what it does and have verified it doesn't interfere with the success path (which also callssetIsReady(true)).