fix(tests): guard localStorage access against Node.js 22 built-in stub#822
Draft
Just-Insane wants to merge 1 commit into
Draft
fix(tests): guard localStorage access against Node.js 22 built-in stub#822Just-Insane wants to merge 1 commit into
Just-Insane wants to merge 1 commit into
Conversation
- debugLogger: wrap constructor localStorage.getItem in try/catch - settings: wrap getSettings/setSettings in try/catch - test/setup.ts: install in-memory localStorage polyfill before jsdom initialises so module-level singleton access resolves correctly All 60 test files (570 tests) now pass on Node.js 22.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Node.js 22 ships a built-in
localStoragestub that throws when accessed in a non-browser environment. The debug logger initialisation code accessedlocalStorageat module load time, causing the test suite to fail under Node 22 before any test ran.Adds a guard so
localStorageis only accessed whenwindow.localStorageis available (i.e. in a real browser context).Type of change
Checklist