fix(room-nav): group DM avatars, ArrowUp edit handling, and unread dots on space tabs#827
Closed
Just-Insane wants to merge 3 commits into
Closed
fix(room-nav): group DM avatars, ArrowUp edit handling, and unread dots on space tabs#827Just-Insane wants to merge 3 commits into
Just-Insane wants to merge 3 commits into
Conversation
…n encrypted rooms - Implement group DM triangle-avatar layout in RoomNavItem (the wider DM list panel). The CSS (GroupAvatarRow/GroupAvatarMini) was already defined in styles.css.ts from feat/dm-list-group-avatars but the JSX implementation was never added. - Fix ArrowUp edit-last-message failing in encrypted rooms: use getEffectiveEvent()?.type instead of getType(), which returns the wire type m.room.encrypted rather than the actual message type.
SpaceTab was using RoomUnreadProvider with the space's own roomId, but space rooms carry no messages so the unread count was always zero. Replace with the same recursive aggregation pattern used by SpaceMenu: useSpaceChildren + useRecursiveChildScopeFactory to gather all descendant room IDs, then useRoomsUnread to sum their unread counts. The SidebarUnreadBadge now lights up correctly whenever any child room (or sub-space room) has unread messages or highlights.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing — these commits have been cherry-picked into feat/dm-list-group-avatars (#816).