Remove private-network project flag gate - #1254
Merged
sc-zenokerr merged 4 commits intoSep 21, 2026
Merged
Conversation
sc-zenokerr
commented
Sep 11, 2026
| hasPrivateNetwork = "true" | ||
| } | ||
| _ = t.Append([]string{project.Name, strconv.FormatBool(project.Default), project.ID, hasPrivateNetwork}) | ||
| _ = t.Append([]string{project.Name, strconv.FormatBool(project.Default), project.ID, "true"}) |
Contributor
Author
There was a problem hiding this comment.
Question: Should I just remove the "Private Network" column completely?
Contributor
Author
There was a problem hiding this comment.
Removed the column
matthieu526-scalingo
left a comment
matthieu526-scalingo
left a comment
Contributor
There was a problem hiding this comment.
Sorry for the unexpected review, I was looking at open PRs before considering a release.
| _ = t.Append([]string{"", ""}) | ||
| _ = t.Append([]string{"Private Network", "true"}) | ||
| _ = t.Append([]string{"", ""}) | ||
| _ = t.Append([]string{"Private Network", "true"}) |
Contributor
There was a problem hiding this comment.
question: is it required to keep this? If it's by default for everyone?
Contributor
Author
There was a problem hiding this comment.
After having tested locally. I added the "Private Network" label back in (without the "true") part in d8cf8ef
Contributor
Author
There was a problem hiding this comment.
┌──────────────────────────────────┬──────────────────────────────────────────┐
│ PROJECT FIELD │ VALUE │
├──────────────────────────────────┼──────────────────────────────────────────┤
│ Name │ has-pn │
│ ID │ prj-2dd8fb1b-e71e-4e94-9bba-ba93adddc408 │
│ Default │ false │
│ Owner │ zeno.kerr │
│ │ │
│ Private Network │ │
│ - ID │ pn-aaf9101f-9ad0-4429-88ce-89abd0186c77 │
│ - Subnet │ 10.240.0.0/22 │
│ - Gateway IP │ 10.240.0.1/22 │
│ - Total number of assignable IPs │ 1021 │
│ - Used IPs count │ 3 │
│ - Used IPs │ 10.240.0.4 │
│ │ 10.240.0.5 │
│ │ 10.240.0.7 │
└──────────────────────────────────┴──────────────────────────────────────────┘
| hasPrivateNetwork = "true" | ||
| } | ||
| _ = t.Append([]string{project.Name, strconv.FormatBool(project.Default), project.ID, hasPrivateNetwork}) | ||
| _ = t.Append([]string{project.Name, strconv.FormatBool(project.Default), project.ID, "true"}) |
sc-zenokerr
marked this pull request as ready for review
September 21, 2026 11:00
matthieu526-scalingo
approved these changes
Sep 21, 2026
| _ = t.Append([]string{" - Used IPs count", strconv.Itoa(privateNetworkInfo.UsedIPsCount)}) | ||
|
|
||
| if len(privateNetworkInfo.UsedIPs) == 0 { | ||
| _ = t.Append([]string{" - Used IPs", "None"}) |
Contributor
There was a problem hiding this comment.
nitpick: is this required? It will already be written 0 the line above.
Contributor
Author
There was a problem hiding this comment.
What would you suggest?
- removing the word "None"
- removing the line altogether
Contributor
There was a problem hiding this comment.
- Removing the line altogether. I don't see a value, as we have the raw number.
sc-zenokerr
deleted the
story/3115/private-network-branch-removal-pr5
branch
September 21, 2026 13:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to [STORY-3115]