feature(app-firwall) Add apps firewalling rules - #1259
Conversation
john-scalingo
commented
Sep 16, 2026
john-scalingo
commented
- Add a changelog entry in the section "To Be Released" of CHANGELOG.md
c91fd91 to
1b7f2d6
Compare
| } | ||
|
|
||
| t := tablewriter.NewWriter(os.Stdout) | ||
| t.Header([]string{"ID", "CIDR", "Label"}) |
There was a problem hiding this comment.
question(nipitck): so we really want the CIDR before the label?
There was a problem hiding this comment.
It makes more sense to me like that but i can swap them if needed
There was a problem hiding this comment.
No all good then, if it makes more sense for you I am fine with it.
| &databaseNetworkConfigurationShowCommand, | ||
|
|
||
| // App firewall rules | ||
| &appFirewallRulesCommand, |
There was a problem hiding this comment.
nitpick:
| &appFirewallRulesCommand, | |
| &appFirewallRulesListCommand, |
There was a problem hiding this comment.
I would say no, the command is named app-firewall-rules not app-firewall-rules-list ?
There was a problem hiding this comment.
I know it's for consistency, but personally I find it more confusing that anything else. But once again, nitpick.
| set-canonical-domain Set a canonical domain. | ||
| unset-canonical-domain Unset a canonical domain. | ||
| db-tunnel Create an encrypted connection to access your database | ||
| destroy Destroy an app /!\ |
There was a problem hiding this comment.
question: shouldn't the new commands be present in that file?
There was a problem hiding this comment.
No since they are in preview, i'll add them once they're out of preview.
| } | ||
|
|
||
| t := tablewriter.NewWriter(os.Stdout) | ||
| t.Header([]string{"ID", "CIDR", "Label"}) |
There was a problem hiding this comment.
No all good then, if it makes more sense for you I am fine with it.
| &databaseNetworkConfigurationShowCommand, | ||
|
|
||
| // App firewall rules | ||
| &appFirewallRulesCommand, |
There was a problem hiding this comment.
I know it's for consistency, but personally I find it more confusing that anything else. But once again, nitpick.
2 participants
