Skip to content

CachingConnector is a poor user experience #61

Open
Open
CachingConnector is a poor user experience#61
Labels
improvementnot sure if want

Description

@Bilge
Bilge
opened on Nov 6, 2019

Having to wrap a connector in CachingConnector just to use caching is not as easy to use as if the cache just worked with any connector. Moreover, cache + connector is a violation of SRP. The cache should be refactored as a separate entity, apart from connectors.

Activity

  1. Bilge
    added
    improvement
    on Nov 6, 2019

  2. Bilge commented on Nov 8, 2019

    @Bilge
    Bilge
    on Nov 8, 2019
    MemberAuthor

    There are a couple of problems with removing CachingConnector in lieu of storing the cache within Porter herself:

    1. The same cache would be used for all Porter providers, whereas CachingConnector permits different providers to use different caches very easily; possibly even for different resources, with some ingenuity.
    2. We want to cache the raw connection data, but Porter only receives record collections, which is not what we want to cache and cannot be cached easily (if at all) anyway.
  3. Bilge
    added
    not sure if want
    on Nov 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    improvementnot sure if want

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions