Skip to content

Make description of a structure mandatory #324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ScriptRaccoon merged 1 commit into from
Aug 10, 2026
Merged

Make description of a structure mandatory #324

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion database/schema/001_structures.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ CREATE TABLE structures (
type TEXT NOT NULL,
name TEXT NOT NULL UNIQUE,
notation TEXT NOT NULL,
description TEXT,
description TEXT NOT NULL,
nlab_link TEXT CHECK (nlab_link IS NULL OR nlab_link like 'https://%'),
dual_structure_id TEXT,
parent TEXT,
Expand Down
2 changes: 1 addition & 1 deletion database/scripts/utils/seed.types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ export type StructureYaml = {
id: string
name: string
notation: string
description: string | null
description: string
nlab_link: string | null
tags: string[]
related: string[]
Expand Down
3 changes: 2 additions & 1 deletion src/lib/commons/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ export type StructureDisplay = {
id: string
name: string
notation: string
description: string | null
description: string
nlab_link: string | null
dual_structure_id: string | null
dual_structure_name: string | null
Expand Down Expand Up @@ -77,6 +77,7 @@ export type SpecialObject = {

export type SpecialMorphism = {
type: string
// null when the morphisms of this type have not been determined
description: string | null
proof: string
}
Expand Down
10 changes: 5 additions & 5 deletions src/pages/CategoryDetailPage.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,13 +43,13 @@
<h3>Special morphisms</h3>

<ul class="with-margins no-bullets">
{#each data.special_morphisms as obj}
{#each data.special_morphisms as morph}
<li>
<TextWithProof proof={obj.proof}>
{#if obj.description}
{obj.type}: {@html obj.description}
<TextWithProof proof={morph.proof}>
{#if morph.description}
{morph.type}: {@html morph.description}
{:else}
{obj.type}: <Fa icon={faQuestion} scale={0.825} />
{morph.type}: <Fa icon={faQuestion} scale={0.825} />
{/if}
</TextWithProof>
</li>
Expand Down
4 changes: 1 addition & 3 deletions src/pages/StructureDetailPage.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,9 +121,7 @@
{/if}
</ul>

{#if structure.description}
<p>{@html structure.description}</p>
{/if}
<p>{@html structure.description}</p>
</section>

<PropertyAssignmentList
Expand Down