Repository navigation
test(mcp): await generation attribution before cycle assertions - #3181
Merged
Merged
Conversation
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
ScriptedAlchemy
changed the base branch from
fix/observability-retirement
to
master
October 8, 2026 07:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The affected-tests MCP fixture waited for the graph, then asserted that the first feedback cycle already contained test attribution. Attribution now prepares in a retained background worker, so the full-workspace CI run could receive a valid
unavailablecycle before that work finished (627 MCP tests passed; this one failed).Add an opt-in readiness method to the existing test harness that pins the current text generation and awaits the canonical attribution scheduler. Only this fixture uses it, inside its existing 60-second deadline. Keep the exact attribution and invalid-handle assertions unchanged; do not retry arbitrary unavailable results or make attribution a prerequisite for ordinary graph access.
Validation: the previously failing MCP test passed (1 passed, 0 failed, 627 filtered out), and Bazel Clippy passed for the affected root unit and MCP test targets.
Fixes #3180