Skip to content

fix(chatgpt): pin browser targets for reproducible bundles - #3220

Merged
ScriptedAlchemy merged 1 commit into
masterfrom
codex/embedded-browser-targets
Oct 9, 2026
Merged

ScriptedAlchemy merged 1 commit into
masterfrom
codex/embedded-browser-targets

Conversation

@ScriptedAlchemy

@ScriptedAlchemy ScriptedAlchemy commented Oct 9, 2026 •

Copy link
Copy Markdown
Owner

The embedded ChatGPT app changed according to browser configuration outside the checkout. A developer-directory .browserslistrc targeting Chrome 51 / Safari 10 was inherited locally, while CI used Rsbuild 2's default targets. That changed both CSS lowering and JavaScript output and caused the byte-for-byte freshness failure in #3219.

Pin the extension's browser targets to the existing Rsbuild 2 defaults (Chrome/Edge 107, Firefox 104, Safari 16), and regenerate the self-contained app through the maintained build script. The generated app is byte-identical to the independent Linux regeneration in #3200; the server bundle is unchanged. The external browser configuration remains untouched.

Verification through the Bazel-managed Node runtime:

  • Real negative check: removing only the target pin makes the canonical app fail check:embedded with the ancestor configuration present.
  • Restoring the pin passes the full embedded app/server freshness check, including CI=true.
  • The regenerated app matches fix(runtime): repair cross-host storage and verification journeys #3200's Linux bytes (477886 bytes; SHA-256 8fb719178d012702fe07f1f3894e45b02bb218f89c51857533bb72ca90e2e9b7).
  • Commitlint and diff checks pass.

Fixes #3219. This completes the cause investigation behind #3200's generated-file refresh and prevents a developer's ancestor configuration from reintroducing it.


Devin Review

@changeset-bot

changeset-bot Bot commented Oct 9, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 77d9af6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@ScriptedAlchemy
ScriptedAlchemy merged commit ef2d835 into master Oct 9, 2026
3 of 7 checks passed

@devin-ai-integration devin-ai-integration Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Devin Review: No Issues Found

Devin Review analyzed this PR and found no bugs or issues to report.

Devin Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(chatgpt): reproduce embedded artifact drift after Rsbuild 2 upgrade

1 participant