VB-20: Add flexible sweep configs and per-efSearch benchmark output#21
Open
nvzm123 wants to merge 14 commits into
Open
VB-20: Add flexible sweep configs and per-efSearch benchmark output#21nvzm123 wants to merge 14 commits into
nvzm123 wants to merge 14 commits into
Conversation
Author
…ated system RAM constraints to fit 80M 96d case
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR updates the benchmark sweep flow to support more flexible algorithm configurations and cleaner
efSearchhandling across generation, execution, and result post-processing.The main change is that sweep definitions can now specify
algorithmsas either the existing dictionary format or a new list-based format. The list format allows multiple entries for the same algorithm with different parameter groups, which makes it easier to express CAGRA/HNSW sweeps where parameters such as graph degree, intermediate graph degree, and HNSW layers need to vary together.Changes
algorithmsentries in sweep configs while preserving compatibility with the existing dictionary format.efSearchas a per-run search parameter instead of expanding it into separate generated configs.efSearchbenchmark outputs into separate result directories when sweeping multiple values.efSearchvalues from benchmark metrics.indexDirPathgeneration for benchmark configs.cagraIntermediateGraphDegree < cagraGraphDegreehnswMaxConn > hnswBeamWidth26.04.0to26.08.0.sweeps_3000.jsonusing the new list-based algorithm format.Compatibility
Existing sweep files that use the previous dictionary-based
algorithmsformat should continue to work. The new list-based format is additive and is intended for sweeps that need multiple parameter groups for the same algorithm.Notes
This change also updates downstream result processing so converted NVIDIA-format output and Pareto marking correctly handle per-
efSearchresult directories.