[docs] decision: browser permissions are managed through grant/deny/reset/override helpers#17677
Open
AutomatedTester wants to merge 3 commits into
Open
[docs] decision: browser permissions are managed through grant/deny/reset/override helpers#17677AutomatedTester wants to merge 3 commits into
AutomatedTester wants to merge 3 commits into
Conversation
…eset/override helpers
bd5fa9f to
9139ba8
Compare
2 tasks
Rename 0007 -> 17677 and explain the user_context argument (isolation unit from 17681), which the helpers and set_permission already accept.
Member
Author
2 tasks
Note in Context that permissions is a Layer 2 module with no Classic equivalent, per the layering decision 17709.
Member
Author
|
Following up now that the layering is written down: I've opened #17709 ("BiDi is exposed in three API layers"), the foundational decision this and the rest of the series sit under. As I said above, I shared everything at once to show the layered thinking — #17709 makes that explicit, with #17681 (browsing-context handles) and #17671 (events) being the other two foundational ones. In that model this permissions ADR is a Layer 2 module decision (I've noted that in its Context), so I'm happy to defer detailed review here until #17709 / #17681 / #17671 settle. One tie-in already in place: the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💥 What does this PR do?
Proposes a design decision record: browser permissions are managed through grant / deny / reset / override helpers.
BiDi exposes one permissions primitive (
permissions.setPermission), already surfaced raw in the bindings. This record makes the high-level convenience layer a recorded cross-binding decision —grant(single or list),deny,reset(one/many/all via client-side tracking), an exception-safeoverride(...)block, plus the low-levelset_permissionescape hatch — so Java/Ruby/.NET/JavaScript converge on the same names and semantics. It is intentionally a superset of Playwright (which has onlygrant_permissions+ bulkclear_permissions).There is a working reference implementation reviewers can see in action: #17631 (the Python high-level permissions API). This ADR links to it from the binding-status table so the exact shape is visible.
🔧 Implementation Notes
docs/decisions/process from [docs] add design decision record process and template #17665 — depends on [docs] add design decision record process and template #17665 landing (adds onlydocs/decisions/0007-*.md).originas required, but the Python reference ([py] Add high-level BiDi permissions API #17631) currently defaults it toNoneand omits it when absent (spec-non-conformant, browser-dependent). The record's normative rule is that every binding must requireoriginor adopt one documented default; the resolution should flow back into [py] Add high-level BiDi permissions API #17631.🤖 AI assistance
💡 Additional Considerations
Completes the set of BiDi ergonomics decision records proposed together (#17671–#17676). Unlike the others, this one already has a code PR (#17631) to anchor it. Cross-binding convergence is tracked in the binding-status table.
🔄 Types of changes