Conversation
|
Thanks for the contribution!
中文感谢你的贡献！
|
|
Claude finished @xinli-sw's task in 3m 48s —— View job Review of PR #3395
Summary: One blocking issue, posted inline. The new Everything else checks out: the image is a public Docker Hub tag, the changelog entry is appended at the tail, 中文摘要：发现一个阻塞问题，已内联评论。共享脚本 其余检查均通过：镜像为公开 Docker Hub 标签，changelog 条目追加在文件末尾， |
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
|
View unofficial run (performance): https://inferencex.semianalysis.com/inference?unofficialRun=36084683489 View unofficial run (accuracy): https://inferencex.semianalysis.com/evaluation?unofficialRun=36084683489 |
There was a problem hiding this comment.
Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.
Beyond the inline findings, I also checked whether doubling VLLM_ENGINE_READY_TIMEOUT_S to 7200s in runners/launch_gb200-nv.sh:113 could cost a sweep its Slurm wall-clock instead of a clean readiness-timeout error — the default SALLOC_TIME_LIMIT for these single-node sweeps is 480 minutes (8h, from the benchmark workflow), comfortably longer than the new 2h engine-ready timeout, so this isn't a practical risk.
Extended reasoning...
Confirmed via runners/runtime_settings.sh and .github/workflows/.yml that SALLOC_TIME_LIMIT for these sweeps defaults to 480 minutes, well above the new 7200s (120 min) VLLM_ENGINE_READY_TIMEOUT_S, so the candidate wall-clock-loss concern is not realistic under current defaults. Separately verified via git diff and runners/.sh that the new DSV41_BLACKWELL_ATTENTION gate is exported only by launch_gb200-nv.sh (not by launch_b200-nscale-slurm.sh, launch_gb300-nv.sh, or launch_h200-dgxc-slurm.sh), so the attention-config args no longer key off GPU_MEM_MIB alone.
|
|
||
| - config-keys: | ||
| - dsv41flash-fp4-b200-vllm-agentic-dspark |
There was a problem hiding this comment.
🟡 (optional) This entry's config-keys list only dsv41flash-fp4-b200-vllm-agentic-dspark and dsv41flash-fp4-gb200-vllm-agentic-dspark, but the fixed script (benchmarks/single_node/agentic/dsv41flash_fp4_vllm_mtp.sh) is also symlinked from dsv41flash_fp4_gb300_vllm_mtp.sh and dsv41flash_fp4_h200_vllm_mtp.sh, so dsv41flash-fp4-gb300-vllm-agentic-dspark and dsv41flash-fp4-h200-vllm-agentic-dspark get the same SIGPIPE fix but aren't listed. Anyone auditing perf-changelog.yaml by config-key for GB300 or H200 will miss this fix's context even though it changed their behavior too. Fix: include every config that resolves to the shared script (b200, gb200, gb300, h200) in config-keys, not just the two SKUs named in the PR title.
Why this was flagged
configs/nvidia-master.yaml:8210 (dsv41flash-fp4-gb300-vllm-agentic-dspark) and configs/nvidia-master.yaml:8239 (dsv41flash-fp4-h200-vllm-agentic-dspark) both point at benchmarks/single_node/agentic/dsv41flash_fp4_vllm_mtp.sh via symlink, the same script whose GPU_MEM_MIB probe is fixed by this diff. perf-changelog.yaml:8851-8852 lists only b200 and gb200 in config-keys for that fix entry (perf-changelog.yaml:8850-8858). AGENTS.md requires perf-changelog entries to reference the affected config keys as the source of truth for what changed. An engineer or tool filtering perf-changelog.yaml by dsv41flash-fp4-gb300-vllm-agentic-dspark or dsv41flash-fp4-h200-vllm-agentic-dspark would not find this SIGPIPE fix despite it changing their runs' behavior, unlike on base where the entry didn't exist for anyone.
Verification: nit. The SIGPIPE fix lives in the shared script benchmarks/single_node/agentic/dsv41flash_fp4_vllm_mtp.sh (diff replaces nvidia-smi ... | head -n1 | tr -d ' ' with GPU_MEM_MIB=$(nvidia-smi ...) + %%$'\n'* + numeric validation). ls -la confirms four vLLM symlinks point at this one file: dsv41flash_fp4_b200_vllm_mtp.sh, gb200, gb300, and h200 all -> dsv41flash_fp4_vllm_mtp.sh. All…
a6a32b1 to
67e2f61
Compare
更新 GB200 DeepSeek-V4.1-Flash vLLM nightly 配方，并在 TP2 和 TP4 使用 FlashInfer 稀疏注意力。
e8c965a to
e08edaa
Compare
|
InferenceX has switched away from unmaintainable bash scripts to YAML files that don't repeat the same stuff over and over again. Please merge the latest |
This branch has not been deployed
2 participants
Pin the GB200 DeepSeek-V4.1-Flash AgentX arm to vLLM nightly
0961bbae. Enable the merged Blackwell sparse indexer settings and select FlashInfer at TP2, MegaAttention at TP4. Preserve the existing topology and memory limits. Also pass the engine readiness timeout from the launcher where needed.The vLLM tracking issue and upstream recipe document the included changes. Local shell, YAML, and exact-key matrix checks pass; GPU sweep and eval are pending.
中文
将 GB200 DeepSeek-V4.1-Flash AgentX 配置固定到 vLLM nightly
0961bbae。启用已合并的 Blackwell 稀疏索引器参数，TP2 选择 FlashInfer，TP4 选择 MegaAttention；保留现有拓扑与显存限制，并由启动脚本传入所需的引擎就绪超时。相关改动见 vLLM 跟踪问题 与上游配方。本地 shell、YAML 和指定配置的矩阵检查通过；GPU sweep 与 eval 待运行。