[Klaud Cold] Update kimik3-fp4-mi355x-atom-agentic-mtp ATOM image to kimi_k3_agentic_0924 - #3456
functionstackx wants to merge 1 commit into
Conversation
…kimi_k3_agentic_0924 Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
7968b98 to
990d921
Compare
|
Thanks for the contribution!
中文感谢你的贡献！
|
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Nothing blocking. The comments below are optional suggestions. There is no need to push a fix for them before merging.
Beyond the inline pr-link finding, I checked whether this speculative-decoding (MTP) image bump needed a draft-model-precision justification paragraph in the perf-changelog entry itself, since the prior entry for this same recipe included one — it doesn't: CONTRIBUTING.md's Draft-model precision requirement is enforced via the CODEOWNER sign-off's additional-detail section, not via changelog-entry text, so the shorter new entry isn't itself a defect on that count.
Extended reasoning...
The diff is a coupled container-image tag bump across the srt-slurm recipe YAML and configs/amd-master.yaml (kept identical as required) plus one appended perf-changelog.yaml entry; no security-sensitive code paths are touched. The confirmed, already-queued inline finding is that the new entry's pr-link is the literal placeholder PRLINK_PLACEHOLDER rather than a real PR URL, breaking traceability that every other entry in the file provides. I additionally verified, from CONTRIBUTING.md's Draft-model precision section, that the missing per-entry draft-precision justification (present in the prior entry but absent here) is not a required field of perf-changelog.yaml — that confirmation lives in the CODEOWNER checklist's additional-detail section instead — so it is not a separate bug in this diff.
Additional findings (outside the current diff — GitHub can't attach inline comments there):
-
🟡
perf-changelog.yaml— The new perf-changelog entry ships with pr-link: PRLINK_PLACEHOLDER instead of a real PR URL, so anyone auditing perf history via pr-link can't trace this image bump back to its PR. Every other entry in the file uses a real https://github.com/.../pull/N link (see line 8965 above), and CONTRIBUTING.md's template at CONTRIBUTING.md:190 also expects that format. Fix: replace PRLINK_PLACEHOLDER with the actual merged PR URL before/at merge time, e.g. by a pre-merge check or bot substitution that fails the build if the literal placeholder reaches main.Why this was flagged
The entry appended at perf-changelog.yaml:8964-8971 has pr-link set to the literal string PRLINK_PLACEHOLDER (line 8971) rather than a URL. This file is described in AGENTS.md as append-only and used to trace which PR caused a perf change. On the base branch, and in every prior entry (e.g. line 8965's pull/3419), pr-link resolves to a real GitHub PR. If this literal reaches main unmodified, tooling or humans grepping perf-changelog.yaml for provenance get a dead placeholder instead of a working link, breaking traceability for this image bump.
Verification: nit. The new perf-changelog entry ends with a literal placeholder rather than a real PR URL: perf-changelog.yaml:8970
pr-link: PRLINK_PLACEHOLDER. This is a real, present defect — the diff appends exactly this line (git diff shows+ pr-link: PRLINK_PLACEHOLDER), and it is the only occurrence of that token in any YAML in the repo (grep confirms one hit). Every prior entry resolves pr-link to…
|
The image has been updated to rocm/atom-dev:nightly_202609251613 in #3407. |
|
View unofficial run (performance): https://inferencex.semianalysis.com/inference?unofficialRun=36221441682 View unofficial run (accuracy): https://inferencex.semianalysis.com/evaluation?unofficialRun=36221441682 |
This branch has not been deployed
2 participants
Summary
Update the ATOM image from
rocm/atom-dev:ubuntu24.04_py3.12_pytorch_release_2.10.0_kimi_k3_agentic_0911to…_kimi_k3_agentic_0924(latest Kimi-K3 AgentX build on Docker Hub, pushed 2026-09-24) for the Kimi-K3 FP4 MI355X ATOM AgentX config.Recipes touched:
kimik3-fp4-mi355x-atom-agentic-mtpChanges:
configs/amd-master.yaml: image bump. This also moves the DCP8 LMCache arms, which still run the legacykimik3_fp4_mi355x_atom_mtp.shscript (srtctl reserves ATOM's kv-transfer-config for disaggregated workers).srt-slurm-recipes/kimik3/atom/mi355x-fp4-mtp/agentic.yaml:containerbump for the TP8 GPU-resident arm (conc 1, 4). The shared atomesh frontendcontainer_imagedigest is unchanged.perf-changelog.yaml: new entry.Image-only. #3407 targets the same config and carries ATOM env tuning (FlyDSL FP8 prefill attention, prefill-decode interval from conc 16); that tuning is not included here.
Test plan
🤖 Generated with Claude Code