Skip to content

[Klaud Cold] Delete benchmarks/single_node/agentic - #3461

Merged
functionstackx merged 1 commit into
mainfrom
klaud/delete-single-node-agentic-folder
Sep 26, 2026
Merged

functionstackx merged 1 commit into
mainfrom
klaud/delete-single-node-agentic-folder

Conversation

@functionstackx

Copy link
Copy Markdown
Collaborator

Summary

Delete the rest of benchmarks/single_node/agentic/ (24 files, −2,973 lines). Single-node AgentX runs as declarative srt-slurm recipes since #3428, and #3460 already removed the 53 unused scripts.

⚠️ Breaks until ported

These still load files from this folder, so they will fail once this merges unless they are ported to srt-slurm recipes first (or their bash-only entries are removed):

Single-node AgentX search-space entries without srt-recipe: (17 groups across 9 configs)

Deleted script Config key
dsv41flash_fp4_mi355x_atom_mtp.sh dsv41flash-fp4-mi355x-atom-agentic-dspark
glm5.2_fp4_mi355x_atom_mtp.sh glm5.2-fp4-mi355x-atom-agentic-mtp
kimik3_fp4_mi355x_atom_mtp.sh kimik3-fp4-mi355x-atom-agentic-mtp (DCP8 LMCache arms)
kimik3_fp4_mi355x_mtp.sh kimik3-fp4-mi355x-vllm-agentic-mtp
minimaxm3_fp4_mi355x_atom_mtp.sh minimaxm3-fp4-mi355x-atom-agentic-mtp
minimaxm3_fp4_mi355x_mtp.sh minimaxm3-fp4-mi355x-vllm-agentic-mtp
qwen3.5_fp4_b300_sglang_mtp.sh qwen3.5-fp4-b300-sglang-agentic-power-ab
qwen3.5_fp8_b300_sglang_mtp.sh qwen3.5-fp8-b300-sglang-agentic-power-ab
qwen3.8next_fp8_h100_mtp.sh qwen3.8next-fp8-h100-sglang-agentic-mtp

Multi-node DeepSeek-V4.1-Flash H100/H200 block32 recipes: benchmarks/multi_node/srt-slurm-recipes/configs/dsv41flash-h{1,2}00-block32.sh run install_h1{0,2}0_block32_configs.py with kernel_configs/h{1,2}00_dsv41_block32, all deleted here.

Also stale after this: the GB200/GB300 launcher fallbacks that build benchmarks/single_node/agentic/... paths (unreached today, since every GB single-node AgentX entry has an srt-recipe:), the minimaxm3_fp4_mi355x_atom_mtp.sh special case in runners/launch_mi355x-amds.sh, and doc mentions.

Test plan

  • Owners of the configs above port them to srt-slurm recipes (or drop the entries) before or alongside this merge.
  • No config or perf-changelog.yaml change, so no sweep is triggered.

🤖 Generated with Claude Code

Single-node AgentX runs as native srt-slurm recipes since #3428, and #3460
removed the unused scripts. Delete the rest of the legacy folder.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for the contribution!

  • Review: If this PR changes files owned by someone other than a repository admin or @SemiAnalysisAI/core, ask one eligible CODEOWNER to complete the latest PR_REVIEW_CHECKLIST.md before contacting a core maintainer on Slack. Follow the template exactly, including As a PR reviewer and CODEOWNER, I have reviewed this and have, so sign-off verification triggers.
  • PR verification: Sweeps only run on labeled PRs. Add full-sweep-fail-fast (strongly recommended); use full-sweep-enabled only when matrix jobs should continue after a failure.
  • After merging: PR authors must ensure all GitHub Actions jobs pass. Transient failures often pass on rerun; see how to rerun failed jobs.
中文

感谢你的贡献!

  • **审阅:**如果 PR 修改的文件归属于仓库管理员及 @SemiAnalysisAI/core 之外的 CODEOWNER,请先联系一位有资格的 CODEOWNER 填写最新的 PR_REVIEW_CHECKLIST.md,再通过 Slack 联系核心维护者。必须严格遵循模板,并保留 As a PR reviewer and CODEOWNER, I have reviewed this and have,才能触发签核验证。
  • **PR 验证:**扫描仅在带有标签的 PR 上运行。强烈建议添加 full-sweep-fail-fast;仅当需要矩阵任务在失败后继续运行时才使用 full-sweep-enabled。
  • **合并后:**PR 作者必须确保所有 GitHub Actions 任务通过。临时性失败通常可以通过重新运行恢复;参见重新运行失败任务的说明。

@functionstackx
functionstackx merged commit 6c1b2b3 into main Sep 26, 2026
6 checks passed
@functionstackx
functionstackx deleted the klaud/delete-single-node-agentic-folder branch September 26, 2026 06:19

@claude claude Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Findings marked 🟡 are optional suggestions and need no follow-up push.

Additional findings (outside the current diff — GitHub can't attach inline comments there):

  • 🔴 benchmarks/single_node/srt-slurm-recipes/dsv41flash/sglang/h100-fp4-mtp/agentic.yaml — Two single-node srt-slurm AgentX recipes already believed migrated off this legacy folder still break after merge: h100-fp4-mtp/agentic.yaml:33 and dsv41flash/sglang/h200-fp4-mtp/agentic.yaml:24 set setup_script: dsv41flash-h100/h200-block32.sh, which runs install_h100/h200_block32_configs.py against kernel_configs/h100_dsv41_block32 -- all deleted by this diff. The PR's own 'Breaks until ported' table names only multi-node dsv41flash-h100/h200-block32.sh configs, omitting these two single-node recipes, so no owner is on the hook to fix them. Fix: restore or repoint the shared configs/dsv41flash-h100/h200-block32.sh setup scripts before deleting the install scripts/kernel_configs, covering both single- and multi-node callers. [also at: benchmarks/single_node/agentic/install_h100_block32_configs.py:48 - Deleting install_h1{0,2}0_block32_configs.py and kernel_configs/h{1,2}00_dsv41_block32 breaks the active multi-node DSv4.1-Flash H100/H200 recipes, which the base branch runs successfully today. benchmarks/multi_node/srt-slurm-recipes/configs/dsv41flash-h100-block32.sh:5 and…; benchmarks/multi_node/srt-slurm-recipes/configs/dsv41flash-h100-block32.sh:5 - Operators running the DSv4.1-Flash H100/H200 multi-node slurm recipes get a hard failure after merge, since this…; +1 more]

    Why this was flagged

    benchmarks/single_node/srt-slurm-recipes/dsv41flash/sglang/h100-fp4-mtp/agentic.yaml:33 and .../h200-fp4-mtp/agentic.yaml:24 set setup_script: dsv41flash-h100/h200-block32.sh. Grep of every .yaml under benchmarks/ shows only these two single-node files reference either script; no multi_node/.yaml does. Those scripts (benchmarks/multi_node/srt-slurm-recipes/configs/dsv41flash-h100-block32.sh:5) run under set -euo pipefail and call install_h100_block32_configs.py against kernel_configs/h100_dsv41_block32, both deleted here. On base these recipes run; after merge the setup step hard-fails with a…

    Verification: normal, acknowledged in diff (the note's "breaks until ported" claim holds; but it mislabels these as multi-node when they are single-node). Two ACTIVE single-node srt-slurm recipes reference the deleted assets via their setup_script and stay unchanged in the tree: - benchmarks/single_node/srt-slurm-recipes/dsv41flash/sglang/h100-fp4-mtp/agentic.yaml:33 `setup_script:… | normal, acknowledged in…

  • 🟡 docs/index.md — Maintainers following docs/index.md, the repo's "mandatory low-context router," hit a dead link after merge: row 46 still points to benchmarks/single_node/agentic/README.md, which this PR deletes entirely. Context rules tell agents to "Open only the focused page" this table names, so any AgentX-benchmark task routed here 404s instead of reaching real docs. Same stale row exists in docs/index_zh.md:46 and is also cited as the authoritative AgentX guide in docs/DOCUMENTATION_PLAN.md:27,44. Fix: remove or repoint all three references (docs/index.md:46, docs/index_zh.md:46, docs/DOCUMENTATION_PLAN.md:27/44) to wherever AgentX documentation now lives (e.g. the srt-slurm-recipes docs), in this same PR.

    Why this was flagged

    docs/index.md:46 is a row in the "Authoritative references" table of the repo's mandatory documentation router, linking to ../benchmarks/single_node/agentic/README.md with description "AgentX trace benchmark implementation". This diff deletes benchmarks/single_node/agentic/README.md (and the whole directory) but does not update this row. Any engineer or coding agent using docs/index.md to find AgentX benchmark docs, per its own "Context rules" ("Open only the focused page ... needed for the task"), gets a missing-file error instead of documentation. On base branch the link resolves; after merge it is dead. The identical stale link also appears in docs/index_zh.md:46, and docs/DOCUMENTATION_PLAN.md:27 and :44 still cite the same deleted README as the authoritative source to consolidate AgentX docs from, so the documentation-migration plan itself now points at nothing.

    Verification: normal (documentation regression this change introduces). docs/index.md line 46 is a live row in the "Authoritative references" table of the doc router: | [benchmarks/single_node/agentic/README.md](../benchmarks/single_node/agentic/README.md) | AgentX trace benchmark implementation |. This PR deletes benchmarks/single_node/agentic/README.md (git diff shows it removed, 65 deletions; Glob…

functionstackx added a commit that referenced this pull request Sep 26, 2026
…/single_node/agentic

reached it:
- Drop the 17 search-space entries without srt-recipe: six configs that were
  entirely bash-based (both B300 Qwen3.5 power A/B keys, qwen3.8next H100,
  Kimi-K3 and MiniMax-M3 MI355X vLLM, DSv4.1 Flash MI355X ATOM) and the ATOM
  LMCache DRAM-offload arms of Kimi-K3, MiniMax-M3 and GLM-5.2 on MI355X.
- Remove the dead dsv41flash bash branches in the GB200/GB300 launchers and
  the MiniMax-M3 ATOM script special case in the MI355X launcher.
- Restore the DSv4.1 Flash H100/H200 block32 installers and kernel configs
  under benchmarks/multi_node/srt-slurm-recipes/configs/dsv41flash-block32/
  and repoint the setup scripts, which the live single-node H100/H200 SGLang
  AgentX recipes run and #3461 broke.
- Point docs and comments at the srt-slurm recipes and srt_agentic.sh.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
functionstackx added a commit that referenced this pull request Sep 26, 2026
… delete configs/deprecated and amd_utils/deprecated (#3463)

* [Klaud Cold] Remove everything that pointed at the deleted benchmarks/single_node/agentic

reached it:
- Drop the 17 search-space entries without srt-recipe: six configs that were
  entirely bash-based (both B300 Qwen3.5 power A/B keys, qwen3.8next H100,
  Kimi-K3 and MiniMax-M3 MI355X vLLM, DSv4.1 Flash MI355X ATOM) and the ATOM
  LMCache DRAM-offload arms of Kimi-K3, MiniMax-M3 and GLM-5.2 on MI355X.
- Remove the dead dsv41flash bash branches in the GB200/GB300 launchers and
  the MiniMax-M3 ATOM script special case in the MI355X launcher.
- Restore the DSv4.1 Flash H100/H200 block32 installers and kernel configs
  under benchmarks/multi_node/srt-slurm-recipes/configs/dsv41flash-block32/
  and repoint the setup scripts, which the live single-node H100/H200 SGLang
  AgentX recipes run and #3461 broke.
- Point docs and comments at the srt-slurm recipes and srt_agentic.sh.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* Drop the DSv4.1 Flash H100/H200 block32 kernel tilings instead of restoring them

Per review: do not re-add the block32 installers and kernel configs.
Remove the restored dsv41flash-block32 assets, the two block32 setup scripts,
the recipes' setup_script entries and the H200 DSV41_BLOCK32_TP env vars; the
H100/H200 SGLang AgentX recipes now run with SGLang's default tilings.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* Drop the KLAUD_DEBUG script pointer (fixed_seq_len is deleted in #3464)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* Delete configs/deprecated and drop remaining fixed_seq_len pointers

- Delete configs/deprecated/{amd,nvidia}-master.yaml; nothing reads them.
  AGENTS.md, docs/configuration-procedures and the Claude review prompt now
  say retired entries are deleted, with git history and perf-changelog.yaml
  as the record.
- Rewrite the add-model-hardware playbook and configuration procedures for
  srt-slurm recipes instead of bash scripts under fixed_seq_len/.
- Point MODELS links, the KLAUD_DEBUG example and a deprecated multi-node
  comment away from the deleted folders.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* Delete benchmarks/multi_node/amd_utils/deprecated

Nothing loads these archived AMD server-registry files or glm5_setup.sh;
the live registries are the models*.yaml and node_excludes.yaml beside
them. configuration-procedures now says retired AMD registry entries are
deleted rather than moved into deprecated/.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

* Revert the docs/waiver/2508.md edit

Leave the historical waiver record unchanged.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
yhl-amd added a commit that referenced this pull request Sep 26, 2026
Main migrated single-node AgentX to native srt-slurm (#3428) and deleted
benchmarks/single_node/agentic (#3461). Accept the script deletion and move
this PR's change into the declarative recipe: bump the engine image to
rocm/atom-dev:nightly_202609231248 (ROCm/ATOM#2366) and set ATOM_PA_FLYDSL=1
and ATOM_PA_FLYDSL_PLAN=1. The bash-only GPU-mask fix no longer applies.
The changelog entry follows the default eval policy.

中文:main 已将单节点 AgentX 迁移到 srt-slurm 并删除旧 bash 脚本。本 PR 改为在
YAML 配方中更新镜像至 nightly_202609231248 并启用 ATOM_PA_FLYDSL /
ATOM_PA_FLYDSL_PLAN;GPU mask 修复随旧脚本一起移除,changelog 采用默认 eval 策略。

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant