Repository navigation
fix: export backups from a consistent database snapshot - #634
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| public async Task Export_ConcurrentCredentialAndMachineCreation_RestoresIntoEmptyDestination() | ||
| { | ||
| const string passphrase = "snapshot-backup-passphrase"; | ||
| var databasePath = Path.Combine(Path.GetTempPath(), $"np-backup-snapshot-{Guid.NewGuid():N}.db"); |
| { | ||
| const string passphrase = "snapshot-backup-passphrase"; | ||
| var databasePath = Path.Combine(Path.GetTempPath(), $"np-backup-snapshot-{Guid.NewGuid():N}.db"); | ||
| var runtimePath = Path.Combine(Path.GetTempPath(), $"np-backup-snapshot-{Guid.NewGuid():N}.json"); |
Capture all database backup sections and counts in one serializable transaction with execution-strategy retries. Count runtime settings from the captured document. Add a concurrent-writer regression that restores the generated archive and verifies references and counts. Fixes #608
Sev7eNup
force-pushed
the
fix/608-consistent-backup
branch
from
October 24, 2026 16:09
3bb36ce to
8df3808
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What & why
Capture all database backup sections and counts in one serializable transaction with execution-strategy retries. Count runtime settings from the captured document.
Add a concurrent-writer regression that restores the generated archive and verifies references and counts.
Fixes #608
The recovery-audit test fixture gives each concurrent context its own connection to a shared in-memory SQLite database, avoiding concurrent use of one connection while preserving every audit assertion.
Testing
Api.Tests:
FullyQualifiedName~Backup|FullyQualifiedName~ProvisioningSeederTests|FullyQualifiedName~DatabaseRecoveryAuditServiceTests— 135 passed. A deterministic concurrent-writer regression verifies that exported archives restore with consistent references and counts.git diff --checkpassed. Full CI runs on this PR.