[E2E][Bug] 'required' status check not running file filters - #758
Open
kieran-osgood-shopify wants to merge 1 commit into
Open
kieran-osgood-shopify wants to merge 1 commit into
kieran-osgood-shopify wants to merge 1 commit into
Conversation
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
kieran-osgood-shopify
removed this pull request from stack #759
September 10, 2026 17:01
kieran-osgood-shopify
added this pull request to stack #762
September 10, 2026 17:02
kieran-osgood-shopify
force-pushed
the
e2e-required
branch
3 times, most recently
from
September 11, 2026 14:41
55a5a41 to
0fb46c1
Compare
Contributor
Author
|
The order-confirmation selector hardening from an earlier head has been removed from this stack. BrowserStack command logs showed a separate Maestro flake: the broad completion regex returned 250 ms after |
Assisted-By: devx/bfa7df54-2e93-42ac-9fa0-2277f848f09f
kieran-osgood-shopify
force-pushed
the
e2e-required
branch
from
September 15, 2026 10:29
0fb46c1 to
ca6bd77
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Coarse filter for e2e test startup is removed
Result: Every non-draft PR will trigger the e2e pipeline
The fine grained filter remains untouched and will continue to ensure we only run the tests we need. e.g. a readme change will finish in around ~20 seconds reporting success
For example, this is what I expected #754 to do instead of reporting a hang

Why
I was adding CodeQL workflow in #754 and noticed the bitrise e2e pipeline didn't report because it didn't match the coarse file filter
This meant that PR's were blocked/hung because the status check never reported any result
File filtering was done at two levels:
Unfortunately this is incompatible with how Github handles required status checks
If the status check doesn't report success or failure, it is hung, this meant PR's were unable to merge
Testing
You can see its working based on #754 running the checks
Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.mdTip
See the Contributing documentation for the full release process per platform.