Document and test preload reuse with instance appearance - #780
Draft
tiagocandido wants to merge 1 commit into
Conversation
11 tasks
tiagocandido
added this pull request to stack #781
September 16, 2026 08:58
tiagocandido
removed this pull request from stack #781
September 16, 2026 12:13
Evaluating SwiftUI modifiers preserves a cached preload, but reuse is decided at presentation: preload decorates the checkout URL with the global appearance, so an instance .appearance(...) that differs from it produces a different decorated URL, which misses and evicts the preload. The README now separates preservation from reuse, and presentation-level tests cover both reuse with matching appearance plus instance-specific chrome modifiers and the miss-and-evict path for a differing appearance. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Assisted-By: devx/b61614bc-75f6-4454-beb1-4d30f281e365
tiagocandido
force-pushed
the
tiagosantos/09-15-preload-appearance-docs-and-tests
branch
from
September 16, 2026 12:32
95773f2 to
c87f4d6
Compare
tiagocandido
added this pull request to stack #725
September 16, 2026 12:33
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack
Top to bottom:
What changes are you making?
Documentation and regression coverage for preload reuse, no behavior change. Evaluating SwiftUI modifiers preserves a cached preload, but that alone doesn't guarantee reuse:
preloaddecorates the checkout URL with the global configuration'sappearance, and the cache is keyed by decorated URL, so presenting with a different instance.appearance(...)misses and evicts the preload. The README didn't cover when a presentation actually reuses a preload.CheckoutConfigurableTestsnow clears the preload cache in setUp/tearDown so cache assertions are order-independent.How to test
Run the Swift package tests.
testPresentationReusesPreloadWhenInstanceAppearanceMatchesPreloadedAppearanceandtestPresentationWithDifferentInstanceAppearanceMissesAndEvictsPreloadcover both paths;CheckoutWebViewTestsstill passes with the added cache hygiene.Before you merge
Important
platforms/swift/README.mdand/orplatforms/android/README.md)Releasing a new Swift version?
ShopifyCheckoutKit.podspecplatforms/swift/Sources/ShopifyCheckoutKit/ShopifyCheckoutKit.swiftplatforms/swift/README.md(major version only)Releasing a new Embedded Checkout Protocol version?
embeddedCheckoutProtocolAndroidinplatforms/android/gradle/libs.versions.tomlprotocol/languages/kotlin/embedded-checkout-protocol/api/embedded-checkout-protocol.apiif the public API changedReleasing a new Android version?
checkoutKitAndroidinplatforms/android/gradle/libs.versions.tomlplatforms/android/README.md🤖 Generated with Claude Code