Fix Maestro input, keyboard dismissal, and launch recovery - #788
Merged
Merged
Conversation
Install this buildOpen Tophat, select your target device, then click Install. Links open on the Mac running Tophat.
Checkout Kit E2E results
|
tiagocandido
approved these changes
Sep 17, 2026
markmur
changed the title
markmur
force-pushed
the
fix/maestro-checkout-text-entry
branch
from
September 18, 2026 08:24
21e7f2f to
084c74f
Compare
markmur
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checkout E2E tests can lose the first character of an address field, tap Pay now while the keyboard is still open, or fail after successfully dismissing it. Android runs can also stall behind a compatibility warning for BrowserStack's helper app.
Read back the focused address field and clear/re-enter it once if the value is incomplete. Detect the iOS keyboard using its delete-key label (
Deleteordelete):Toolbarremains exposed on iOS 27 after dismissal, which previously triggered an unnecessary second tap. Prefer Done, fall back to the checkmark, retry a missed dismissal once, and require the keyboard to close before submission. During Android launch recovery, dismiss only the warning matching both BrowserStack's helper name and the compatibility message.Validation: Maestro 2.4.0 offline fixtures cover truncated input and replacement, a persistent toolbar after dismissal, missed-tap recovery, retry exhaustion, repeated dismissal, numeric/text keyboards, and Pay now/Review order submission. Android fixtures cover launch recovery with the known warning and preserve unrelated dialogs. Script checks pass: 321 tests, 858 assertions, one existing skip. Local devices run iOS 26.2 and Android 14 (API 34); BrowserStack iOS 27/Android 17 confirmation is pending.