Conversation
Add ShopifyAcceleratedCheckoutButtons custom element as an empty, accessible placeholder under the @shopify/checkout-kit/wallets subpath. - src/wallets.ts: element class with attribute-backed scalar properties (store-domain, country, language, cart-id, variant-id, selling-plan-id, wallet-count) and bidirectional attribute/property reflection. - src/wallets-web-component.ts: side-effect registration of the <shopify-accelerated-checkout-buttons> tag. - src/wallets-index.ts: package entry point re-exporting the class. - src/wallets.test.ts: vitest/happy-dom tests covering registration, reflection, walletCount coercion, placeholder rendering, and connect/disconnect idempotency. - sample/wallets.html: local dev page demonstrating property reflection. - Build wiring: package.json exports, sideEffects, vite multi-entry, and sample vite alias. No runtime dependencies, no network calls, no wallet logic. Assisted-By: devx/9eeb3f82-e284-440b-a1e8-a2ebb0299422
rsomlette
force-pushed
the
wallets/component-shell
branch
3 times, most recently
from
September 17, 2026 20:19
01408ae to
562d50a
Compare
rsomlette
force-pushed
the
wallets/component-shell
branch
from
September 17, 2026 20:43
562d50a to
0d78a48
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Adds a first-class Wallets view to the web playground (
pnpm sample,/wallets.html) for testing<shopify-accelerated-checkout-buttons>, built with the same shell, settings panel, state, storage, and event-log patterns as the existing checkout demo.Related: https://github.com/shop/issues-checkout/issues/14751
Settings (persisted in localStorage)
cartCreatevia the Storefront API and writes the returned GID tocart-idvariant-id, optionalselling-plan-idCenter workspace
/products.json)Events panel
cart.creating/cart.created/cart.errorevents from the Storefront API callwallets.render,wallets.error) wired in — names centralised inWALLETS_EVENT_TYPESElement scaffold changes
layoutattribute/property (horizontaldefault,vertical)log-levelattribute/property (sharedLoggerfromsrc/logger.ts)wallets.types.ts—WalletsAttributes,WalletsProperties,WalletsLayoutinterfaces (mirrorscheckout.types.ts)implements WalletsAttributes, WalletsPropertiescreateTemplate(html...)+cloneNode(matches checkout element)@attributeannotations for the custom elements manifestrenderProducts/renderCart/selectGeneratedCartUrl/createProductLoaderto accept interfaces so both demos share the same view codeNew files
src/wallets.types.tssample/storefront-api.tscartCreateStorefront API helper (testable, injectable fetcher)sample/wallets-main.tssample/wallets-state.tssample/wallets-storage.tssample/wallets-dom.tssample/wallets-shell.tssample/wallets-render.tssample/views/wallets-settings.tssample/views/wallets-element.tssample/views/wallets-log.tssample/views/log-entries.ts+ .test.ts for eachChecks
pnpm test— 353 tests passpnpm lint— typecheck + sample:typecheck + oxlint + format ✅pnpm build+pnpm sample:build✅