Closed
Conversation
fbbc97e to
db5300e
Compare
db5300e to
ed0a5b4
Compare
Contributor
Author
|
/snapit |
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
/snapit |
Contributor
|
🫰✨ Thanks @gonzaloriestra! Your snapshot has been published to npm. Test the snapshot by installing your package globally: npm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260413103432Caution After installing, validate the version by running |
99a2666 to
fb5508e
Compare
4c45ff4 to
e8fd655
Compare
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/node-package-manager.d.ts@@ -60,6 +60,10 @@ export declare class FindUpAndReadPackageJsonNotFoundError extends BugError {
export declare function packageManagerFromUserAgent(env?: NodeJS.ProcessEnv): PackageManager;
/**
* Returns the dependency manager used in a directory.
+ * Walks upward from so workspace packages (e.g. )
+ * still resolve to the repo root lockfile ().
+ * If no lockfile is found, it falls back to the package manager from the user agent.
+ * If the package manager from the user agent is unknown, it returns 'npm'.
* @param fromDirectory - The starting directory
* @returns The dependency manager
*/
|
Contributor
Author
|
Closing in favor of #7254 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Function extensions is running
graphql-code-generatorwithnpm execinstead of using the project's package manager.Also, we should align internal tooling with the repo’s default package manager (pnpm), so contributors and CI use the same commands.
WHAT is this pull request doing?
buildGraphqlTypes: Runsgraphql-code-generatorwith the project's package manager instead of hard-codingnpm exec.create-appscript: Passes--package-manager pnpminto the create-app dev entrypoint.packageManagerinpackages/e2e/setup/app.tsispnpmwhenE2E_PACKAGE_MANAGERis unset; Playwright steps intests-pr.ymlusepnpm exec playwrightso CI uses the workspace’s pinned Playwright (avoidspnpxpulling a different version). E2E helper script comments / create-app flows updated for pnpm where relevant.dev.yml,build-dev-docs.sh,create-notification-pr.js,release.yml) for consistency with pnpm-first usage.How to test your changes?
pnpm i -g --@shopify:registry=https://registry.npmjs.org @shopify/cli@0.0.0-snapshot-20260413103432shopify app generate extension --template cart_transform --flavor typescript --name cart-transformerChecklist
pnpm changeset add