[Refactor] Use uniq helper in scopes#7772
Conversation
This PR refactors `packages/cli-kit/src/private/node/session/scopes.ts` to use the standardized `uniq` utility function from `@shopify/cli-kit/common/array` instead of manual `Array.from(new Set(array))` pattern for deduplicating scope arrays. This improves code consistency and readability by utilizing existing project utilities. Verified with lint, type-check, and unit tests.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
github-actions
Bot
added
the
no-changelog
This PR refactors `packages/cli-kit/src/private/node/session/scopes.ts` to use the standardized `uniq` utility function from `@shopify/cli-kit/common/array` instead of manual `Array.from(new Set(array))` pattern for deduplicating scope arrays. This improves code consistency and readability by utilizing existing project utilities. Verified with lint, type-check, and unit tests. Note that some pre-existing CI failures were observed but confirmed to be unrelated to these changes.
This PR refactors \`packages/cli-kit/src/private/node/session/scopes.ts\` to use the standardized \`uniq\` utility function from \`@shopify/cli-kit/common/array\` instead of manual \`Array.from(new Set(array))\` pattern for deduplicating scope arrays. This improves code consistency and readability by utilizing existing project utilities. Verified with lint, type-check, and unit tests. Note that some pre-existing CI failures (organization app limit reached) were observed but are unrelated to these changes.
1 participant
What's in this PR?
Refactored
packages/cli-kit/src/private/node/session/scopes.tsto use theuniqhelper from@shopify/cli-kit/common/arrayinstead of manualSetdeduplication.How to test your changes?
CI
PR created automatically by Jules for task 4960416436050537126 started by @gonzaloriestra