Fix og:image string shorthand using name instead of property attribute#3688
Open
J8118 wants to merge 1 commit intoShopify:mainfrom
Open
Fix og:image string shorthand using name instead of property attribute#3688J8118 wants to merge 1 commit intoShopify:mainfrom
J8118 wants to merge 1 commit intoShopify:mainfrom
Conversation
Open Graph meta tags require the property attribute, not name. The object-path code and all other og:* tags already use property correctly — this was the only inconsistency. Updated tests to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title
Fix og:image string shorthand using
nameinstead ofpropertyin SEO tagsDescription
Summary
In
generate-seo-tags.tsline 452, whenmediais a string, the Open Graph image tag is generated withname: 'og:image'instead ofproperty: 'og:image'. Per the Open Graph protocol, allog:*tags should use thepropertyattribute, notname.The object-path code (line 481) correctly uses
property, and all otherog:*tags in the same file useproperty— this is the only inconsistency, indicating a copy-paste oversight.File changed:
packages/hydrogen/src/seo/generate-seo-tags.ts(line 452)Before:
After:
Test plan
property="og:image"notname="og:image"