Fix SEO description validation threshold to match error message#3689
Open
J8118 wants to merge 1 commit intoShopify:mainfrom
Open
Fix SEO description validation threshold to match error message#3689J8118 wants to merge 1 commit intoShopify:mainfrom
J8118 wants to merge 1 commit intoShopify:mainfrom
Conversation
The validation rejected descriptions longer than 155 characters but the error message said the limit was 160. Aligned the threshold to 160 to match the message and standard SEO guidance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
generate-seo-tags.ts, the description validation rejects values longer than 155 characters (value.length > 155), but the error message tells the user the limit is 160 characters. A 156-character description would be rejected with the message "should not be longer than 160 characters" — which is contradictory.Standard SEO guidance typically recommends ~155-160 characters. The fix should align the threshold with the message.
File changed:
packages/hydrogen/src/seo/generate-seo-tags.ts(lines 36-41)Change threshold to match message: