Skip to content

Remove oj dependency to restore JRuby support #1462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
najibna wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove oj dependency to restore JRuby support #1462

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4fc310a
Remove unused oj dependency
najibna Sep 20, 2026
3c37c6c
Add changelog entry for removing oj
najibna Sep 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@

Note: For changes to the API, see https://shopify.dev/changelog?filter=api
## Unreleased
- [#1462](https://github.com/Shopify/shopify-api-ruby/pull/1462) Remove unused `oj` dependency to restore JRuby support.

## 16.3.0 (2026-08-04)
- [#1443](https://github.com/Shopify/shopify-api-ruby/pull/1443) Add `ShopifyAPI::Utils::ShopValidator` with `sanitize_shop_domain` and `sanitize!`.
Expand Down
5 changes: 0 additions & 5 deletions Gemfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ PATH
httparty
jwt
logger
oj
openssl
securerandom
sorbet-runtime
Expand Down Expand Up @@ -68,11 +67,7 @@ GEM
multi_xml (0.6.0)
mutex_m (0.3.0)
netrc (0.11.0)
oj (3.16.7)
bigdecimal (>= 3.0)
ostruct (>= 0.2)
openssl (3.2.0)
ostruct (0.6.1)
parallel (1.24.0)
parser (3.3.0.5)
ast (~> 2.4.1)
Expand Down
1 change: 0 additions & 1 deletion lib/shopify_api.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@

$LOAD_PATH.unshift(File.dirname(__FILE__))

require "oj"
require "sorbet-runtime"
require "securerandom"
require "cgi"
Expand Down
1 change: 0 additions & 1 deletion shopify_api.gemspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,6 @@ Gem::Specification.new do |s|
s.add_runtime_dependency("httparty")
s.add_runtime_dependency("jwt")
s.add_runtime_dependency("logger")
s.add_runtime_dependency("oj")
s.add_runtime_dependency("openssl")
s.add_runtime_dependency("securerandom")
s.add_runtime_dependency("sorbet-runtime")
Expand Down
274 changes: 0 additions & 274 deletions sorbet/rbi/gems/oj@3.13.11.rbi
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion sorbet/tapioca/require.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
require "minitest/autorun"
require "mocha"
require "mocha/minitest"
require "oj"
require "securerandom"
require "sorbet-runtime"
require "uri"
Expand Down
Loading