Skip to content

Expose request ID after token refresh - #1463

Open
najibna wants to merge 1 commit into
Shopify:mainfrom
najibna:feat/expose-refresh-request-id-1453
Open

najibna wants to merge 1 commit into
Shopify:mainfrom
najibna:feat/expose-refresh-request-id-1453

Conversation

@najibna

@najibna najibna commented Sep 20, 2026

Copy link
Copy Markdown

Description

Fixes #1453

Keeps the existing Session return type and attaches Shopify's x-request-id to the session after a successful refresh. Failed refreshes expose the same ID on HttpResponseError#request_id.

This preserves backward compatibility instead of introducing a new result object.

How has this been tested?

  • bundle exec ruby -Itest test/auth/refresh_token_test.rb
  • bundle exec srb tc

Checklist:

  • My commit message follow the pattern described in here
  • I have performed a self-review of my own code.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have updated the project documentation.
  • I have added a changelog line.

@najibna

najibna commented Sep 20, 2026

Copy link
Copy Markdown
Author

I have signed the CLA!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide a way to access the request-id when refreshing an access token

1 participant