Drop the benchmark dependency - #2407
Conversation
|
Thanks for the PR. Can you fix typechecking errors? |
065a67c to
38e669c
Compare
|
Oops, yeah |
|
We have addressed a few CI issues this week, which should make this PR's build green. Can you rebase the PR? Thx |
38e669c to
1b0f472
Compare
1b0f472 to
947c6f8
Compare
|
Based on CI failures, it looks like some dev dependencies Tapioca relies on ( |
74b819e to
102b942
Compare
|
How about now? |
Looks like something needs to be fixed on the tests side. |
102b942 to
d97196d
Compare
It is trivial, don't have to take on a dependency for that. The test change is because activesupport 7.1.0 itself doesn't depend on `benchmark` properly
d97196d to
5d98291
Compare
|
Right, some test requires real rails (and activesupport) 7.1.0 which doesn't declare the dependency. I bumped the test to the latest patch release and that should resolve it |
Motivation
tapioca currently depends on the
benchmarkgem because of a change to Ruby bundled gems. The functionality is trivial though, and I don't think you have to take on a dependency for that.Implementation
Just use
Process.clock_gettimedirectly.Tests
No behaviour change. I just ran some cli commands and they still print the time in seconds. Probably the output is also already asserted against somewhere.