Repository navigation
Fix ActiveJob perform_now return types for rescued errors - #2759
Open
efegokdemir wants to merge 2 commits into
Open
efegokdemir wants to merge 2 commits into
efegokdemir wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
When an ActiveJob rescue handler handles an exception,
perform_nowreturns the exception object. Tapioca currently copies theperformreturn type, so generated RBIs can omit a value thatperform_nowreturns.Implementation
Include
Exceptionin the generated return type when rescue handlers are registered. UseT.untypedforvoidperform signatures, which cannot be combined with another return type.Tests
Added specs for typed and
voidperform methods with rescue handlers. Ruby syntax checks andgit diff --checkpassed. The focused spec could not start because the lockfile'sparacycle/json_api_clientGit dependency is not checked out locally.Closes #2353