Repository navigation
Fix IdentityCache multi-fetch return types - #2763
Open
efegokdemir wants to merge 2 commits into
Open
efegokdemir wants to merge 2 commits into
efegokdemir wants to merge 2 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
fetch_multi_*_by_*methods generated forcache_attributereturn a hash keyed by the lookup values, but Tapioca currently types them as arrays. This gives Sorbet incorrect signatures for map access. Fixes #1770.Implementation
Generate hash return types for
cache_attributemulti-fetch methods: unique fields map to the attribute type, and non-unique fields map to arrays. Keepcache_indexsignatures unchanged. Add regression coverage for both cases.Tests
Ruby 4.0.2 syntax checks and
git diff --checkpassed. The focused IdentityCache spec could not run because the lockedjson_api_clientGit dependency is not checked out andminitest-hooksis unavailable.