Repository navigation
Port WorldGen.HardModeTileUpdate hook to v1.4.5.8 - #173
Open
13en3volen7 wants to merge 1 commit into
Open
13en3volen7 wants to merge 1 commit into
13en3volen7 wants to merge 1 commit into
Conversation
Owner
|
Nice, this is on my list for review when time permits. Fwiw typically I'd prefer 1.4.5+/variances branched out so previous versions can be retained (something that's in the works relies upon it), but I'm ok to look past this for now |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves the hardmode biome spread issue reported in Pryaxis/TShock#3303, Pryaxis/TShock#3293.
From v1.4.5 onwards, direct tile type updates have been wrapped inside
WorldGen.Convert. This change prevented the script from finding the target instructions to insert the hook, making it pretty much ineffective.