Add BlendWithCoverage overloads. Optimize Rgba32 compatible shuffling.#3150
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prerequisites
Description
This pull request introduces new blending functionality to support raster coverage in Porter-Duff composition operations and thoroughly tests these new methods. The main focus is on adding the
BlendWithCoveragemethods for different vector types and ensuring their correctness through comprehensive unit tests.New blending functionality:
BlendWithCoveragemethods toPorterDuffFunctionsforVector4,Vector256<float>, andVector512<float>, which apply raster coverage to Porter-Duff composition results. These methods handle premultiplied alpha blending and un-premultiplication for accurate compositing.These methods are used by ImageSharp Drawing for proper composition in the canvas.
Testing and validation:
PixelBlenderTests.csto verify the correctness of the newBlendWithCoveragemethods. These tests cover various scenarios, including constant and span sources, varying coverage and amount arrays, and usage of working buffers.ExerciseBlenderhelper method to include calls to the newBlendWithCoverageoverloads, ensuring all blending paths are tested for expected output. [1] [2]