Add bounded debugger performance tracing - #161
Conversation
📊 PR Size: size/XLTotal changes: 4449 lines (28 files) Top files changed:
...and 18 more files Size calculated as additions + deletions. Labels: XS (<10), S (<50), M (<250), L (<1000), XL (1000+) |
|
| Test Suite | Result |
|---|---|
| macOS: C++ & Platform Tests | ❌ failure |
| valdi_web Integration Test | ✅ success |
| Linux: Build Compiler | ✅ success |
| API Surface Check | ✅ success |
| Valdi Smoke Tests | ✅ success |
| Snapshot Tests | ✅ success |
| Linux: Module Tests | ✅ success |
| Linux: Registry Validation | ✅ success |
| Test Coverage Delta | ✅ success |
| Linux: C++ Tests | ✅ success |
| Linux: Hotreload Smoke | ✅ success |
| Linux: Build & Export | ✅ success |
Some tests failed. Please check the workflow logs for details.
🚀 Bazel remote cache is now enabled - future builds will be faster!
Workflow: Valdi CI
clholgat
left a comment
There was a problem hiding this comment.
Please carry this feedback into the squashed PR(s).
🟢 Low — runTraceTransition (npm_modules/cli/src/debugger/server.ts) serializes trace start/stop/capture across ALL targets and ports through a single process-wide traceTransitionInProgress flag. During a one-shot capture (up to 15s) the flag is held for the whole window, so a manual stop of any other target/context is rejected with "Another renderer trace transition is already in progress," and an in-progress capture cannot be aborted. (Status polling is intentionally not gated, so it stays responsive.) Mirrors the existing profileTransitionInProgress pattern, so it's a conservative choice rather than a data bug — but consider keying the in-progress guard per target (port/clientId/contextId) so unrelated targets aren't blocked.
Description
Adds lifecycle-safe, bounded performance tracing across the CLI, renderer, runtime, and native tracer layers.
Type of Change
Testing
bazel test //...)Testing Details
npm testpassed 436/436; the CLI production build passed.//src/valdi_modules/src/valdi/web_renderer:testpassed.bazel query //...passed.Checklist
Related Issues
Relates to #154
Additional Context
Stack 8/22. Stacked on #160 (
bjd/debugger-settings). Review this PR as the single incremental commit06be7132against that base; do not merge it before its parent.