Skip to content

Add debugger persistent-storage provider - #163

Draft
bjdodson-openai wants to merge 1 commit into
bjd/debugger-providersfrom
bjd/debugger-storage-provider
Draft

Add debugger persistent-storage provider#163
bjdodson-openai wants to merge 1 commit into
bjd/debugger-providersfrom
bjd/debugger-storage-provider

Conversation

@bjdodson-openai

Copy link
Copy Markdown
Collaborator

Description

Registers PersistentStore inspection as a thin consumer of the generic debugger-provider framework.

  • Preserves the existing persistence implementation and read-only snapshot contract.
  • Reports availability truthfully per target and generation.
  • Keeps response serialization within the generic provider envelope.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • Documentation improvement
  • Performance optimization
  • Test improvement
  • Other (new debugger capability)

Testing

  • Tests pass locally (bazel test //...)
  • Added/updated tests for changes (if applicable)
  • Tested on multiple platforms (iOS/Android/Web/macOS as applicable)
  • Manual testing performed (describe below)

Testing Details

  • Incremental branch: CLI 283/283 and browser renderer 5/5 passed; persistence native/web Bazel targets, TypeScript, lint, syntax, format, and boundary checks passed.
  • Assembled debugger stack: npm test passed 436/436; the CLI production build passed.
  • Focused //src/valdi_modules/src/valdi/web_renderer:test passed.
  • bazel query //... passed.
  • The broad Valdi suite reproduced the established 12 unrelated failures; all new debugger specs passed.

Checklist

  • Code follows project style guidelines
  • Documentation updated (if needed)
  • No breaking changes (or documented in description)
  • Commit messages follow conventional format
  • No secrets, API keys, or internal URLs included

Related Issues

Relates to #154

Additional Context

Stack 10/22. Stacked on #162 (bjd/debugger-providers). Review this PR as the single incremental commit 6b72c93b against that base; do not merge it before its parent.

@github-actions

Copy link
Copy Markdown

📊 PR Size: size/L

Total changes: 970 lines (7 files)

Top files changed:

  • src/valdi_modules/src/valdi/persistence/src/PersistentStoreDebuggerProvider.ts: +627 -0
  • src/valdi_modules/src/valdi/persistence/test/PersistentStoreDebuggerProvider.spec.ts: +221 -0
  • npm_modules/cli/src/debugger/browserTools.spec.ts: +66 -0
  • npm_modules/cli/debugger/debugger-providers.js: +22 -4
  • npm_modules/cli/debugger/README.md: +11 -12
  • docs/docs/stdlib-persistence.md: +5 -1
  • src/valdi_modules/src/valdi/persistence/src/PersistentStore.ts: +1 -0

Size calculated as additions + deletions. Labels: XS (<10), S (<50), M (<250), L (<1000), XL (1000+)

@github-actions github-actions Bot added the area/docs Documentation label Aug 26, 2026
@github-actions

Copy link
Copy Markdown

⚠️ Bazel & CI Test Results

Test Suite Result
valdi_web Integration Test ✅ success
macOS: C++ & Platform Tests ❌ failure
API Surface Check ✅ success
Snapshot Tests ✅ success
Linux: C++ Tests ✅ success
Valdi Smoke Tests ✅ success
Test Coverage Delta ✅ success
Linux: Build & Export ✅ success
Linux: Registry Validation ✅ success
Linux: Module Tests ✅ success
Linux: Hotreload Smoke ✅ success
Linux: Build Compiler ✅ success

Some tests failed. Please check the workflow logs for details.

🚀 Bazel remote cache is now enabled - future builds will be faster!

Workflow: Valdi CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docs Documentation size/L

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant