Skip to content

Add opt-in web tracing to the debugger - #166

Draft
bjdodson-openai wants to merge 1 commit into
bjd/debugger-component-hierarchyfrom
bjd/debugger-web-tracing-compat
Draft

Add opt-in web tracing to the debugger#166
bjdodson-openai wants to merge 1 commit into
bjd/debugger-component-hierarchyfrom
bjd/debugger-web-tracing-compat

Conversation

@bjdodson-openai

Copy link
Copy Markdown
Collaborator

Description

Adds opt-in web tracing and configuration against Snap's existing web runtime.

  • Keeps tracing disabled until explicitly enabled by the host.
  • Uses injectable time sources so standalone and browser runtimes behave consistently.
  • Preserves exact target identity and reload-safe registration.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • Documentation improvement
  • Performance optimization
  • Test improvement
  • Other (new debugger capability)

Testing

  • Tests pass locally (bazel test //...)
  • Added/updated tests for changes (if applicable)
  • Tested on multiple platforms (iOS/Android/Web/macOS as applicable)
  • Manual testing performed (describe below)

Testing Details

  • Incremental branch: CLI 307/307, focused identity/reload 94/94, and new web tracing/query 26/26 passed; web-renderer Bazel passed all 112 specs.
  • Assembled debugger stack: npm test passed 436/436; the CLI production build passed.
  • Focused //src/valdi_modules/src/valdi/web_renderer:test passed.
  • bazel query //... passed.
  • The broad Valdi suite reproduced the established 12 unrelated failures; all new debugger specs passed.

Checklist

  • Code follows project style guidelines
  • Documentation updated (if needed)
  • No breaking changes (or documented in description)
  • Commit messages follow conventional format
  • No secrets, API keys, or internal URLs included

Related Issues

Relates to #154

Additional Context

Stack 13/22. Stacked on #165 (bjd/debugger-component-hierarchy). Review this PR as the single incremental commit 3304c1bb against that base; do not merge it before its parent.

@github-actions

Copy link
Copy Markdown

📊 PR Size: size/L

Total changes: 621 lines (14 files)

Top files changed:

  • src/valdi_modules/src/valdi/web_renderer/test/ValdiWebTracing.spec.ts: +237 -0
  • src/valdi_modules/src/valdi/web_renderer/src/tracing/ValdiWebTracing.ts: +93 -0
  • src/valdi_modules/src/valdi/web_renderer/src/tracing/ChromeDevToolsTracing.ts: +86 -0
  • src/valdi_modules/src/valdi/web_renderer/test/ChromeDevToolsTracing.spec.ts: +64 -0
  • src/valdi_modules/src/valdi/web_renderer/src/utils/LocationQuery.ts: +41 -0
  • src/valdi_modules/src/valdi/web_renderer/test/LocationQuery.spec.ts: +39 -1
  • src/valdi_modules/src/valdi/web_renderer/src/tracing/WebTracingConfiguration.ts: +25 -0
  • src/valdi_modules/src/valdi/web_renderer/src/ValdiWebRuntime.ts: +9 -3
  • npm_modules/cli/debugger/README.md: +4 -3
  • npm_modules/cli/src/utils/owlCdpClient.spec.ts: +2 -2

...and 4 more files

Size calculated as additions + deletions. Labels: XS (<10), S (<50), M (<250), L (<1000), XL (1000+)

@github-actions

Copy link
Copy Markdown

⚠️ Bazel & CI Test Results

Test Suite Result
API Surface Check ✅ success
macOS: C++ & Platform Tests ❌ failure
Test Coverage Delta ✅ success
Snapshot Tests ✅ success
Linux: Build & Export ✅ success
valdi_web Integration Test ✅ success
Linux: Registry Validation ✅ success
Linux: Module Tests ✅ success
Valdi Smoke Tests ✅ success
Linux: Hotreload Smoke ✅ success
Linux: C++ Tests ✅ success
Linux: Build Compiler ✅ success

Some tests failed. Please check the workflow logs for details.

🚀 Bazel remote cache is now enabled - future builds will be faster!

Workflow: Valdi CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant