Skip to content

Add exact component-property editors - #174

Draft
bjdodson-openai wants to merge 1 commit into
bjd/debugger-component-property-edit-protocolfrom
bjd/debugger-component-property-edit
Draft

Add exact component-property editors#174
bjdodson-openai wants to merge 1 commit into
bjd/debugger-component-property-edit-protocolfrom
bjd/debugger-component-property-edit

Conversation

@bjdodson-openai

Copy link
Copy Markdown
Collaborator

Description

Adds inline scalar component-property editors over the preceding exact edit protocol.

  • Preserves focused edits across polling and edit-owned refreshes.
  • Rejects stale generations and reports renderer failures without false success.
  • Keeps native and unsupported targets strictly read-only.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • Documentation improvement
  • Performance optimization
  • Test improvement
  • Other (new debugger capability)

Testing

  • Tests pass locally (bazel test //...)
  • Added/updated tests for changes (if applicable)
  • Tested on multiple platforms (iOS/Android/Web/macOS as applicable)
  • Manual testing performed (describe below)

Testing Details

  • Incremental branch: Full CLI 414/414 and production build passed; focused web-renderer Bazel, broad exact baseline, repository query, and two independent frozen-tree reviews passed.
  • Assembled debugger stack: npm test passed 436/436; the CLI production build passed.
  • Focused //src/valdi_modules/src/valdi/web_renderer:test passed.
  • bazel query //... passed.
  • The broad Valdi suite reproduced the established 12 unrelated failures; all new debugger specs passed.

Checklist

  • Code follows project style guidelines
  • Documentation updated (if needed)
  • No breaking changes (or documented in description)
  • Commit messages follow conventional format
  • No secrets, API keys, or internal URLs included

Related Issues

Relates to #154

Additional Context

Stack 21/22. Stacked on #173 (bjd/debugger-component-property-edit-protocol). Review this PR as the single incremental commit 6c62eef0 against that base; do not merge it before its parent.

@github-actions

Copy link
Copy Markdown

📊 PR Size: size/XL

Total changes: 1144 lines (4 files)

Top files changed:

  • npm_modules/cli/src/debugger/devtoolsPanel.spec.ts: +629 -14
  • npm_modules/cli/debugger/devtools-panel.js: +372 -12
  • npm_modules/cli/debugger/README.md: +62 -7
  • npm_modules/cli/debugger/devtools-panel.css: +48 -0

Size calculated as additions + deletions. Labels: XS (<10), S (<50), M (<250), L (<1000), XL (1000+)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant