Skip to content

Add reviewable ClientSQL generator sources - #176

Draft
bjdodson-openai wants to merge 1 commit into
bjd/debugger-providersfrom
bjd/client-sql-generator
Draft

Add reviewable ClientSQL generator sources#176
bjdodson-openai wants to merge 1 commit into
bjd/debugger-providersfrom
bjd/client-sql-generator

Conversation

@bjdodson-openai

Copy link
Copy Markdown
Collaborator

Description

Adds reviewable and hermetic ClientSQL generator sources plus compiler integration, without exposing the native runtime.

  • Uses one generated-symbol registry and comment-aware parameter lexing.
  • Declares cross-package generator inputs so source and executed toolchains stay reproducible.
  • Adds a real hermetic Bazel test target for generated output.

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • Documentation improvement
  • Performance optimization
  • Test improvement
  • Other (new ClientSQL capability)

Testing

  • Tests pass locally (bazel test //...)
  • Added/updated tests for changes (if applicable)
  • Tested on multiple platforms (iOS/Android/Web/macOS as applicable)
  • Manual testing performed (describe below)

Testing Details

  • Hermetic ClientSQL generator Bazel target passed 9/9.
  • Generator syntax, formatting, diff, and generated-symbol checks passed.
  • The completed optional side stack later passed all 19 generator tests, native tests, runtime integration, focused builds, and repository-wide Bazel analysis.

Checklist

  • Code follows project style guidelines
  • Documentation updated (if needed)
  • No breaking changes (or documented in description)
  • Commit messages follow conventional format
  • No secrets, API keys, or internal URLs included

Related Issues

Relates to #154

Additional Context

Optional side stack from generic providers #162 (bjd/debugger-providers). This ClientSQL stack is not required by the core debugger chain. Review this PR as the single incremental commit 2a6c0df1 against that base.

@github-actions github-actions Bot added area/compiler Valdi compiler area/build-system Bazel build rules and config size/XL labels Aug 26, 2026
@github-actions

Copy link
Copy Markdown

📊 PR Size: size/XL

Total changes: 2690 lines (13 files)

Top files changed:

  • compiler/clientsql/test_clientsql.py: +947 -0
  • compiler/clientsql/src/clientsql/typescript.py: +726 -0
  • compiler/clientsql/src/clientsql/sql.py: +680 -0
  • compiler/clientsql/src/clientsql/cli.py: +97 -0
  • compiler/clientsql/package_clientsql.py: +76 -0
  • compiler/clientsql/src/clientsql/model.py: +59 -0
  • compiler/clientsql/BUILD.bazel: +50 -0
  • compiler/clientsql/README.md: +27 -0
  • compiler/compiler/Compiler/Sources/Processors/ClientSqlProcessor.swift: +7 -3
  • compiler/clientsql/run_generated_javascript.js: +9 -0

...and 3 more files

Size calculated as additions + deletions. Labels: XS (<10), S (<50), M (<250), L (<1000), XL (1000+)

@github-actions

Copy link
Copy Markdown

⚠️ Bazel & CI Test Results

Test Suite Result
Snapshot Tests ✅ success
valdi_web Integration Test ✅ success
Valdi Smoke Tests ✅ success
Linux: Build Compiler ✅ success
macOS: C++ & Platform Tests ❌ failure
Linux: C++ Tests ✅ success
API Surface Check ✅ success
Test Coverage Delta ✅ success
Linux: Module Tests ✅ success
Linux: Registry Validation ✅ success
Linux: Hotreload Smoke ✅ success
Linux: Build & Export ✅ success

Some tests failed. Please check the workflow logs for details.

🚀 Bazel remote cache is now enabled - future builds will be faster!

Workflow: Valdi CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/build-system Bazel build rules and config area/compiler Valdi compiler size/XL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant