Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
effectifybefore resuming the logging effect. A rejected logger Promise now rejectsrunAsync()with the same error.Validation
npm run typecheck,npm run lint, andnpm run test-types(37 proofs) pass with the locked toolchain. Prettier passes for all three changed files.unhandledRejection.Existing runtime limitation
When an
effectifyPromise rejects,runAsync()rejects without re-entering the suspended program'scatchorfinally. This example fix preserves that existing behavior; generator unwinding needs a separate runtime change.CI
CI run 39261259204 passed for
94e10aa6a1388dc8ee40366cc638f1c14db3b4a1: lint, typecheck, and type-proof/runtime tests on Node 18, 20, and 22.