Skip to content

Nightly: gem unwind-after-unconverged-supersede e2e fails on bundler 1.17.3/2.1.4 #1685

Open

Description

The nightly CI run on main (39907645034, head aa69125) fails both old-bundler e2e-extended legs:

  • e2e-extended (ubuntu-latest, e2e_redirect_gem_build e2e_vendor_gem_build, 3.1, 2.1.4)
  • e2e-extended (ubuntu-latest, e2e_redirect_gem_build e2e_vendor_gem_build, 3.1, 1.17.3)

Failing test: gem_hosted_unwind_after_unconverged_supersede_undoes_the_new_block (e2e_redirect_gem_build, 31 passed / 1 failed). It panics at crates/socket-patch-cli/tests/e2e_redirect_gem_build.rs:2346:

rollback: Gemfile:
source "http://127.0.0.1:45027/upstream"
source "http://127.0.0.1:45027/patch-registry/gem/44444444-4444-4444-8444-444444444444/10000000-1a2b-4a1b-8c2d-3e4f5a6b7c8d/" do
  gem "vuln-gem", "1.0.0"
end

The test and its fix both arrived in #1664 (e2b8914, "Fix gem rollback leaving superseding Gemfile block (#1626)"), merged 2026-10-22. PR CI and the merge queue don't run the --ignored gem capstones on the old-bundler legs, so this only shows up in the nightly. e2e_vendor_gem_build passes on the same legs.

This doesn't block merging (ci-ok doesn't include nightly-only legs), but it keeps the nightly on main red. It needs someone to look at the gem unwind path under bundler < 2.2. Either the gen-3 superseding block isn't written in the expected window, or rollback leaves it behind.


Generated by Claude Code

Activity

  1. mikolalysenko commented on Oct 23, 2026

    @mikolalysenko
    CollaboratorAuthor

    [agent] Claiming this issue (shared root cause: on bundler < 2.2 the superseding re-scan refuses with redirect_unattributable on the merged GEM section, so the test's unconverged-window premise never occurs). Branch: agent/fix-ci-gem-unwind-old-bundler. Claim-ID: 2026-10-23T06:58:57Z-211f2f


    Generated by Claude Code

  2. mikolalysenko commented on Oct 23, 2026

    @mikolalysenko
    CollaboratorAuthor

    [agent] Fix PR: #1687. On bundler < 2.2 the superseding re-scan refuses the new pin (redirect_unattributable, merged GEM section), so the test now asserts that refusal on those eras instead of the unconverged window. Reproduced red on bundler 2.1.4 locally; green after.


    Generated by Claude Code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions