Preserve PR context and fix dependency comment accuracy - #302
Open
lelia wants to merge 10 commits into
Open
Conversation
lelia
force-pushed
the
lelia/patched-version-and-pr-context
branch
from
September 2, 2026 23:10
e3e708b to
695703b
Compare
lelia
marked this pull request as ready for review
September 2, 2026 23:10
lelia
force-pushed
the
lelia/patched-version-and-pr-context
branch
from
September 2, 2026 23:12
695703b to
3cd0355
Compare
lelia
marked this pull request as draft
September 3, 2026 18:50
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
The GitHub comment adapter and pull request link construction each parsed BUILDKITE_REPO independently. Consolidate on socketsecurity.core.git_remote, which also reports the remote host (needed for self-hosted GitHub Enterprise and GitLab) and preserves nested GitLab subgroup paths. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
external_href is only honored while a diff scan is being created, so a re-run over the same before/after pair left the Dashboard report with no link back to its pull request. Send on_duplicate=update alongside it, which applies the link to the existing diff scan and answers 200 with the same envelope as a create. The 409-and-resolve path is retained for runs with no pull request context and for deployments that predate on_duplicate=update. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
lelia
force-pushed
the
lelia/patched-version-and-pr-context
branch
from
September 3, 2026 19:14
3cd0355 to
0e03a6f
Compare
lelia
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implementation notes
Pull request context is resolved from explicit configuration first, then from standard provider CI variables. An explicitly supplied zero still disables association.
The diff scan link is sent with
on_duplicate=update, allowing reruns of an existing before/after pair to attach the change URL. Deployments that do not support that behavior retain the existing conflict-resolution fallback.Dependency change categories remain distinct in the report model and overview table. Alert comparison still treats updated dependencies as part of the current scan and replaced dependencies as part of the baseline, preserving the existing blocking semantics.
Generated ignore commands now include the ecosystem, while parsing remains compatible with older bare package commands and splits scoped package names from their version at the final
@.With an SCM adapter active, the detected event type is authoritative: only pull request or merge request events create diff scans. API-only diff flags cannot turn an ordinary branch pipeline into a diff scan.
Testing
579 passed, 2 skippedacrosstests/unitandtests/coreRefs: CE-94, CE-215, CE-337, CE-376, CE-424, CE-441