Skip to content

fix contents and primary pane in 3dots - #252

Merged
SharonStrats merged 3 commits into
stagingfrom
fix/contents
Oct 27, 2026
Merged

SharonStrats merged 3 commits into
stagingfrom
fix/contents

Conversation

@SharonStrats

@SharonStrats SharonStrats commented Oct 27, 2026 •

Copy link
Copy Markdown
Contributor

This fixes the issue we had where the primary pane was not showing up in the 3dots and when you selected Contents the pane was showing instead of the folder view.

it also changes the expensive three-dot action-menu pane discovery so that it is no longer done for every resource on initial render. It is deferred until the action menu is opened

Added in debug instead of console as well.

Ran all the e2e tests.

@SharonStrats
SharonStrats requested a balanced review from Copilot October 27, 2026 05:18
@SharonStrats SharonStrats self-assigned this Oct 27, 2026
@SharonStrats SharonStrats added the bug Something isn't working label Oct 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Interrupted loads can block menu retries after reconnecting, and document-load failures prevent fallback pane actions from appearing.

2 open issues
What changed in this PR

This PR updates the folder browser’s three-dot menus to distinguish folder contents from application views and prioritize the preferred pane.

Changes:

  • Load pane actions on demand, placing the preferred pane before Contents.
  • Route explicit folder selections to the container view.
  • Update access metadata when loading resource actions.
File Description
src/​components/​folder-pane-view/​FolderPaneView.ts Handles explicit folder selections and sets folder rendering options.
src/​components/​folder-pane-container/​FolderPaneContainer.ts Adds on-demand menu loading, preferred-pane ordering, and Contents actions.

Review effort: Balanced

Comment thread src/components/folder-pane-container/FolderPaneContainer.ts
Comment thread src/components/folder-pane-container/FolderPaneContainer.ts Outdated
@SharonStrats
SharonStrats merged commit d0687ff into staging Oct 27, 2026
8 checks passed
@github-project-automation github-project-automation Bot moved this from In review to Done in SolidOS NLNet UI Oct 27, 2026
@SharonStrats
SharonStrats deleted the fix/contents branch October 27, 2026 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Contents menu item on the 3dots should show the folder-pane-container

2 participants