Repository navigation
fix contents and primary pane in 3dots - #252
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Interrupted loads can block menu retries after reconnecting, and document-load failures prevent fallback pane actions from appearing.
2 open issues
What changed in this PR
This PR updates the folder browser’s three-dot menus to distinguish folder contents from application views and prioritize the preferred pane.
Changes:
- Load pane actions on demand, placing the preferred pane before Contents.
- Route explicit folder selections to the container view.
- Update access metadata when loading resource actions.
| File | Description |
|---|---|
| src/components/folder-pane-view/FolderPaneView.ts | Handles explicit folder selections and sets folder rendering options. |
| src/components/folder-pane-container/FolderPaneContainer.ts | Adds on-demand menu loading, preferred-pane ordering, and Contents actions. |
Review effort: Balanced
SharonStrats
force-pushed
the
fix/contents
branch
from
October 27, 2026 07:32
5f155f1 to
57a6ba2
Compare
SharonStrats
force-pushed
the
fix/contents
branch
from
October 27, 2026 08:23
db5707f to
8150aac
Compare
…@5.0.2-4) (latest: rdflib@2.4.1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This fixes the issue we had where the primary pane was not showing up in the 3dots and when you selected Contents the pane was showing instead of the folder view.
it also changes the expensive three-dot action-menu pane discovery so that it is no longer done for every resource on initial render. It is deferred until the action menu is opened
Added in debug instead of console as well.
Ran all the e2e tests.