Repository navigation
images only and more than one - #782
Merged
Merged
Conversation
…@5.0.2-4 pane-registry@5.0.2-1 folder-pane@4.0.1-1 profile-pane@4.1.0-0 source-pane@4.0.1-0) (latest: rdflib@2.4.1 activitystreams-pane@2.0.0 chat-pane@4.0.0 contacts-pane@4.0.0 issue-pane@4.0.0 meeting-pane@4.0.0)
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Duplicate containment entries still enable the slideshow for a single distinct image.
1 open issue
What changed in this PR
This PR restricts the slideshow pane to folders containing multiple images and no other resource types.
Changes:
- Requires more than one containment entry, all identified as images.
- Shares image filtering between pane selection and rendering.
- Adds tests for single-image, mixed-content, and multiple-image folders.
| File | Description |
|---|---|
test/unit/slideshowPane.test.ts |
Adds tests for slideshow eligibility. |
src/slideshow/slideshowPane.js |
Tightens eligibility and centralizes image filtering. |
Review effort: Balanced
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slideshow was showing when there were other files in the folder i don't think this is correct, also there was only one image.