Repository navigation
change message when a user has multiple sharing types on a container … - #911
Open
SharonStrats wants to merge 2 commits into
Open
SharonStrats wants to merge 2 commits into
SharonStrats wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The revised warning suggests combined edits are available, but mixed policies still disable all editing and saving.
1 open issue
What changed in this PR
This PR revises the access-control modal’s warning for containers with different folder and contents permissions.
Changes:
- Replaces the warning’s explanation without changing editing behavior.
- Updates the corresponding test expectation.
| File | Description |
|---|---|
test/components/access-control-modal.test.ts |
Updates the expected warning text. |
src/components/access-control-modal/AccessControlModal.ts |
Revises the mixed-policy warning message. |
Review effort: Balanced
| <div class="access-control-mixed-policy-warning" role="alert"> | ||
| <strong>This container has different access settings for the folder and its contents.</strong> | ||
| <span>Changing this mixed policy is an advanced feature. You can still change access for the folder or its contents separately below.</span> | ||
| <span>Currently you can only add and/or update access on the folder and contents combined.</span> |
SharonStrats
force-pushed
the
access-error-msg
branch
from
October 27, 2026 10:37
856c0bd to
49a1a8f
Compare
…istry@5.0.2-1) (latest: rdflib@2.4.1)
timea-solid
reviewed
Oct 27, 2026
timea-solid
left a comment
timea-solid
left a comment
Member
There was a problem hiding this comment.
We need to work on this some more.
I see the point and I need to think about it some more.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This message appears when someone has already set multiple different types of permissions on a container folder so for instance instead of just having folder and contents which we are supporting now, they may have also added folder only or contents only. it let's them know about this and understand they can't change the other access yet.
