Skip to content

No errors when text-block-define is unable to read the file #90

Description

@ywkaras

& worse, when a request comes through using that text-block, it doesn't even inject anything!!!

Example:

-rwx------ 1 vinithb users 5 Nov 23 23:41 /home/y/conf/trafficserver/ssl/athenz/mail.backend.jedi.jws.acl_jedi.acl.token.atz.jws.ycpi.yahoo.jwt 
    - text-block-define:
        name: "JWT-mail_cloud-mail.backend.jedi.jws.acl_jedi.acl.token.atz.jws.ycpi.yahoo.jwt"
        path: "/home/y/conf/trafficserver/ssl/athenz/mail.backend.jedi.jws.acl_jedi.acl.token.atz.jws.ycpi.yahoo.jwt"
        duration: "1m" 

Expectation:
Since this is a per-remap plugin, ATS can't fatal but at a minimum, we need an entry in diags/error.log and/or 502 the request.

Found by Yahoo YCPI (Vineeth Bindiganavale). Internal Yahoo issue ID: YTSATS-4083.

This issue was probably seen in 0.4.10 .

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions