SONARJAVA-6431 Centralize Tree.Kind assignments

[aurelien-coet-sonarsource]

---

Summary by Gitar

• API enhancements:
  • Added centralized lists CLASS_KINDS and ASSIGNMENT_KINDS to Tree.Kind for cleaner visitor node registration.
• Refactoring:
  • Replaced explicit lists of class-like and assignment kinds across Java checks and frontend visitors with the new centralized constants.

_{This will update automatically on new commits.}

[hashicorp-vault-sonar-prod]

SONARJAVA-6431

[gitar-bot]

💡 Bug: ExpressionComplexityCheck now scopes enum/interface bodies

Previously nodesToVisit() and the visitNode/leaveNode/isInsideEquals branches only treated CLASS and RECORD as complexity-reset boundaries; switching to Tree.Kind.CLASS_KINDS additionally treats ENUM, INTERFACE, ANNOTATION_TYPE and IMPLICIT_CLASS as boundaries that push/pop a fresh count/level scope. This changes how S1067 counts operators for expressions inside enum/interface/annotation bodies, so reported issues may differ, yet no test accompanies this behavior change (unlike RedundantNullabilityAnnotationsCheck). Confirm the new scoping is intended and add a test covering an expression inside an enum/interface, or restrict this check to the previous CLASS/RECORD set if the broadening is unintended.

_{Was this helpful? React with 👍 / 👎}

[gitar-bot]

Code Review 👍 Approved with suggestions 0 resolved / 1 findings

Centralizes class-like and assignment kinds into Tree.Kind and updates Java checks and frontend visitors to use them. ExpressionComplexityCheck now scopes enum and interface bodies alongside CLASS and RECORD.

💡 Bug: ExpressionComplexityCheck now scopes enum/interface bodies

📄 java-checks/src/main/java/org/sonar/java/checks/ExpressionComplexityCheck.java:58 📄 java-checks/src/main/java/org/sonar/java/checks/ExpressionComplexityCheck.java:111 📄 java-checks/src/main/java/org/sonar/java/checks/ExpressionComplexityCheck.java:124 📄 java-checks/src/main/java/org/sonar/java/checks/ExpressionComplexityCheck.java:143

Previously nodesToVisit() and the visitNode/leaveNode/isInsideEquals branches only treated CLASS and RECORD as complexity-reset boundaries; switching to Tree.Kind.CLASS_KINDS additionally treats ENUM, INTERFACE, ANNOTATION_TYPE and IMPLICIT_CLASS as boundaries that push/pop a fresh count/level scope. This changes how S1067 counts operators for expressions inside enum/interface/annotation bodies, so reported issues may differ, yet no test accompanies this behavior change (unlike RedundantNullabilityAnnotationsCheck). Confirm the new scoping is intended and add a test covering an expression inside an enum/interface, or restrict this check to the previous CLASS/RECORD set if the broadening is unintended.

🤖 Prompt for agents

Code Review: Centralizes class-like and assignment kinds into Tree.Kind and updates Java checks and frontend visitors to use them. ExpressionComplexityCheck now scopes enum and interface bodies alongside CLASS and RECORD.

1. 💡 Bug: ExpressionComplexityCheck now scopes enum/interface bodies
   Files: java-checks/src/main/java/org/sonar/java/checks/ExpressionComplexityCheck.java:58, java-checks/src/main/java/org/sonar/java/checks/ExpressionComplexityCheck.java:111, java-checks/src/main/java/org/sonar/java/checks/ExpressionComplexityCheck.java:124, java-checks/src/main/java/org/sonar/java/checks/ExpressionComplexityCheck.java:143

   Previously nodesToVisit() and the visitNode/leaveNode/isInsideEquals branches only treated CLASS and RECORD as complexity-reset boundaries; switching to Tree.Kind.CLASS_KINDS additionally treats ENUM, INTERFACE, ANNOTATION_TYPE and IMPLICIT_CLASS as boundaries that push/pop a fresh count/level scope. This changes how S1067 counts operators for expressions inside enum/interface/annotation bodies, so reported issues may differ, yet no test accompanies this behavior change (unlike RedundantNullabilityAnnotationsCheck). Confirm the new scoping is intended and add a test covering an expression inside an enum/interface, or restrict this check to the previous CLASS/RECORD set if the broadening is unintended.

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
94.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[mostafa-mohammed-sonarsource]

✅, but I believe the base branch needs to be ac/SONARJAVA-6430