Skip to content

SONARJAVA-7182 Replace frequently allocated streams with loops #6349

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aurelien-coet-sonarsource merged 2 commits into from
Oct 15, 2026
Merged

SONARJAVA-7182 Replace frequently allocated streams with loops #6349

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6aa942
Replace the stream in JMethodSymbol.findOverridesInTypes with a for loop
aurelien-coet-sonarsource Oct 13, 2026
fb155dc
Replace streams in MethodMatchersList with loops
aurelien-coet-sonarsource Oct 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 15 additions & 5 deletions java-frontend/src/main/java/org/sonar/java/matcher/MethodMatchersList.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@

import java.util.ArrayList;
import java.util.List;
import java.util.function.Predicate;
import org.sonar.plugins.java.api.semantic.MethodMatchers;
import org.sonar.plugins.java.api.semantic.Symbol;
import org.sonar.plugins.java.api.tree.MethodInvocationTree;
Expand All @@ -35,27 +36,36 @@ public MethodMatchersList(List<? extends MethodMatchers> matchers) {

@Override
public boolean matches(NewClassTree newClassTree) {
return matchers.stream().anyMatch(matcher -> matcher.matches(newClassTree));
return matchesAny(matcher -> matcher.matches(newClassTree));
}

@Override
public boolean matches(MethodInvocationTree mit) {
return matchers.stream().anyMatch(matcher -> matcher.matches(mit));
return matchesAny(matcher -> matcher.matches(mit));
}

@Override
public boolean matches(MethodTree methodTree) {
return matchers.stream().anyMatch(matcher -> matcher.matches(methodTree));
return matchesAny(matcher -> matcher.matches(methodTree));
}

@Override
public boolean matches(MethodReferenceTree methodReferenceTree) {
return matchers.stream().anyMatch(matcher -> matcher.matches(methodReferenceTree));
return matchesAny(matcher -> matcher.matches(methodReferenceTree));
}

@Override
public boolean matches(Symbol symbol) {
return matchers.stream().anyMatch(matcher -> matcher.matches(symbol));
return matchesAny(matcher -> matcher.matches(symbol));
}

private boolean matchesAny(Predicate<MethodMatchers> predicate) {
for (MethodMatchers matcher : matchers) {
if (predicate.test(matcher)) {
return true;
}
}
return false;
}

}
12 changes: 6 additions & 6 deletions java-frontend/src/main/java/org/sonar/java/model/JMethodSymbol.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,6 @@
import java.util.List;
import java.util.Set;
import java.util.function.Predicate;
import java.util.stream.Stream;
import javax.annotation.Nullable;
import org.eclipse.jdt.core.dom.ASTUtils;
import org.eclipse.jdt.core.dom.IMethodBinding;
Expand Down Expand Up @@ -158,11 +157,12 @@ void findOverridesInParentTypes(Collection<MethodSymbol> accumulator, Predicate<
private void findOverridesInTypes(Collection<MethodSymbol> accumulator, Predicate<IMethodBinding> overridesCondition, ITypeBinding... types) {
for (ITypeBinding type : types) {
if (type != null) {
Stream.of(type.getDeclaredMethods())
.filter(overridesCondition)
.findFirst()
.map(sema::methodSymbol)
.ifPresent(accumulator::add);
for (IMethodBinding declaredMethod : type.getDeclaredMethods()) {
if (overridesCondition.test(declaredMethod)) {
accumulator.add(sema.methodSymbol(declaredMethod));
break;
}
}
findOverridesInParentTypes(accumulator, overridesCondition, type);
}
}
Expand Down
Loading