SONARJAVA-7162 Implement rule S9435 - Ternary operator conditions should not be negated

[rombirli]

Implements rule S9435, which raises on a ternary expression whose condition is negated (!x or x != y), since the reader has to invert the condition mentally before pairing each result with the case it belongs to.

Null checks are exempt: value != null ? value.name() : "unknown" reads naturally as a positive guard, and so does its long form !(value == null). Only the top-level condition is considered, so value != null && count != 0 ? ... : ... does not raise. if statements are out of scope by design, as decided on the RSPEC.

RSPEC: https://github.com/SonarSource/rspec/pull/8337 (branch rule/add-RSPEC-S9435, not merged yet)
Jira: https://sonarsource.atlassian.net/browse/SONARJAVA-7162

[hashicorp-vault-sonar-prod]

SONARJAVA-7162

[github-actions]

⚖️ Ruling update ready for review: #6355

[github-actions]

Ruling Diff Summary

Detected changes in 1 rule files: 0 issues removed, 3 issues added.

S9435 (java) on sonarqube-6.5 - 0 issues removed, 3 issues added - new ruling file

Added src/main/java/org/sonar/server/debt/DebtRulesXMLImporter.java (line 254)

(source file not found at this revision: src/main/java/org/sonar/server/debt/DebtRulesXMLImporter.java)

Added src/test/java/org/sonar/server/issue/IssueDocTesting.java (line 69)

(source file not found at this revision: src/test/java/org/sonar/server/issue/IssueDocTesting.java)

Added src/test/java/org/sonar/server/issue/IssueDocTesting.java (line 74)

(source file not found at this revision: src/test/java/org/sonar/server/issue/IssueDocTesting.java)

[gitar-bot]

Code Review ✅ Approved

🟡 Medium risk · Adding S9435 flags negated ternary conditions in analyzed projects, which could introduce new issues and affect quality-gate results.

Adds rule S9435 to flag ternary expressions whose top-level condition is negated (!x or x != y), excluding null checks such as value != null ? ... : ... and their !(value == null) form. No issues found.

Verification Repos 3 inspected

Functional validation No results

Rules No rules evaluated

Cross-repo 3 repositories inspected 0 open impacts

SonarSource/sonarlint-language-server Inspected
SonarSource/sonarlint-vscode Inspected
SonarSource/sonar-java-symbolic-execution Inspected

Auto-approval Not enabled

Set up

_{For more verification details, comment gitar display:verbose.}

Options

Auto-apply is off → Gitar will not commit updates to this branch.
Display: compact → Showing compact verification results.

Comment with these commands to change the behavior for this request:

Auto-apply	Compact
gitar auto-apply:on	gitar display:verbose

_{Was this helpful? React with 👍 / 👎 | Gitar}

[sonarqube-next]

Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

[rombirli]

/pvf

[hashicorp-vault-sonar-prod]

📊 Performance Validation complete
🆕 557 new · 🗑️ 0 lost issues
View dashboard

[hashicorp-vault-sonar-prod]

📊 Performance Validation complete
🆕 8 new · 🗑️ 0 lost issues
View dashboard

[hashicorp-vault-sonar-prod]

📊 Performance Validation complete
🆕 557 new · 🗑️ 0 lost issues
View dashboard