SLCORE-2061 SLCORE-2062 On-demand analyzers.#1941
Merged
damien-urruty-sonarsource merged 29 commits intomasterfrom Apr 15, 2026
Merged
SLCORE-2061 SLCORE-2062 On-demand analyzers.#1941damien-urruty-sonarsource merged 29 commits intomasterfrom
damien-urruty-sonarsource merged 29 commits intomasterfrom
Conversation
nquinquenel
changed the title
nquinquenel
force-pushed
the
feature/on-demand-analyzers
branch
2 times, most recently
from
d422d29 to
8a4a4e0
Compare
|
damien-urruty-sonarsource
force-pushed
the
feature/on-demand-analyzers
branch
3 times, most recently
from
a6492c5 to
6a2ef4a
Compare
Use a single Utils class to trigger analysis, wait for completion and for issues/hotpots raise calls, consume and return issues.
…ad is completed.
* SLCORE-2062 Introduce standalone artifacts loading strategy Add the ArtifactSource interface, the standalone source implementations (EmbeddedPluginSource, BinariesArtifactSource) and their supporting infrastructure (ArtifactState, ArtifactOrigin, ResolvedArtifact, …), together with StandaloneArtifactsLoadingStrategy and ArtifactsLoadingStrategy interface. Renames commons Plugin → EnterpriseReplacement to reflect its meaning. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * SLCORE-2062 Move binaries utilities to plugin/source package OnDemandPluginCacheManager, OmnisharpDistributionDownloader, OnDemandPluginSignatureVerifier, UniqueTaskExecutor and DownloadableArtifact were pure package moves; delete the old files and update imports in SonarLintSpringAppConfig and AnalysisSchedulerCache. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * SLCORE-2062 Fix compilation of standalone branch - Delete plugin.ArtifactState (now in plugin.source.ArtifactState) - Update all imports from plugin.ArtifactState to source.ArtifactState - Update old resolver files: ArtifactSource enum -> ArtifactOrigin - Apply PluginStatusMapper from main refactoring commit - Update ResolvedArtifact to use source.ArtifactState and ArtifactOrigin - Add missing imports in resolver dead-code files for moved classes - Make OnDemandPluginSignatureVerifier.verify() and OnDemandPluginCacheManager.cleanupOldVersions() public Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * SLCORE-2062 Fix test compilation of standalone branch - Add ArtifactState and ArtifactOrigin imports to tests in plugin package (previously accessed without import as same-package types) - Replace ArtifactSource enum values with ArtifactOrigin in tests - Fix resolved() helper method signatures in resolver tests - Add OnDemandPluginSignatureVerifier and DownloadableArtifact imports to OnDemandArtifactResolverTest (classes moved out of resolvers package) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * SLCORE-2062 Delete ondemand plugins.properties test resource This file belonged to the old OnDemandArtifactResolver which is removed as part of this refactoring. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * SLCORE-2062 Fix medium test after DownloadableArtifact package move Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * PR review --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
* PR review * SLCORE-2062 Introduce connected artifacts loading strategy Add ServerPluginSource, ServerPluginDownloader, ServerPluginsCache and ConnectedArtifactsLoadingStrategy (with its factory) to handle plugin resolution in connected mode via the new ArtifactSource architecture. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * SLCORE-2062 Move ServerPluginDownloader and ServerPluginsCache to plugin/source/server Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * SLCORE-2062 Fix test compilation of connected branch - Add ServerPluginsCache import to ConnectedModeArtifactResolverTest (class moved from plugin to plugin.source.server) - Add ServerPluginDownloader import to ConnectedModeCompanionPluginResolverTest (class moved from plugin.resolvers to plugin.source.server) - Restore refreshAndGet method in ServerPluginsCache (was missing from the move) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * PR review * PR review * Fix logic around text enterprise plugin --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
) * SLCORE-2062 Wire artifacts loading strategies into PluginsService Replace the old resolver chain (EmbeddedArtifactResolver, ConnectedModeArtifactResolver, …) with the new ArtifactsLoadingStrategy / ArtifactSource abstraction in PluginsService and SonarLintSpringAppConfig. Delete all old resolver classes and update AnalysisService, LanguageSupportRepository, PluginStatus and the medium tests accordingly. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * SLCORE-2062 Align wiring branch with original plugin-sources branch - Revert cleanupOldVersions and verify to package-private (were widened temporarily to compile dead-code resolvers) - Remove ServerPluginsCache.refreshAndGet (not in original, not called by production code) - Remove corresponding refreshAndGet test case from ServerPluginsCacheTest - Restore {@link ServerPluginSource} Javadoc + import in ArtifactSource - Fix import ordering in SonarLintSpringAppConfig (ServerPlugin* after SkippedPlugins*) Intentional improvements kept over original: - ArtifactState/ArtifactOrigin imports in test files (needed for compilation) - ServerPluginsCacheTest moved to source/server/ package (matches production code location) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> * Move classes * Bot review * PR review --------- Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
damien-urruty-sonarsource
force-pushed
the
feature/on-demand-analyzers
branch
from
8a5a48a to
b32110d
Compare
* SLCORE-2062 Fix support for sonarlint-omnisharp * Do not load Omnisharp if dependencies are missing * Use a single way to sync server plugins * Factorize the plugins synchronization * Avoid using the fork-join pool * PR review * Fix text developer sync * Fix consecutive reset commands
SummarySummaryThis PR refactors SonarLint Core's plugin/artifact management to support on-demand analyzers—downloading plugins and their dependencies (like OmniSharp for C#) from Key changes:
Removes deprecated What reviewers should knowReviewer GuideWhere to Start
Key Implementation Details
Areas to Watch
Non-Obvious Decisions
|
![sonar-review-alpha[bot]](https://avatars.githubusercontent.com/in/3025063?s=60&v=4){kind=small}
|
damien-urruty-sonarsource
approved these changes
Apr 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.