Repository navigation
BED-9989 Collect selected app installation repositories - #81
Open
jaredcatkinson wants to merge 9 commits into
Open
jaredcatkinson wants to merge 9 commits into
jaredcatkinson wants to merge 9 commits into
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configuration
📒 Files selected for processing (28)
Included review availability: This review used your included allowance. 2 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour. WalkthroughThis change adds enterprise classic personal access token inventory and selected-repository access collection for GitHub App installations. It adds graph models, relationships, navigation, documentation, and tests for both features. ChangesClassic PAT Inventory
Selected Installation Repository Access
Priority: ➖ Normal Estimated code review effort: 4 (Complex) | ~45 minutes Change: Feature Sequence Diagram(s)sequenceDiagram
participant EnterpriseResource
participant CredentialExportAPI
participant CSVDownload
participant ClassicPATModel
EnterpriseResource->>CredentialExportAPI: create or poll export
CredentialExportAPI-->>EnterpriseResource: export status and download URL
EnterpriseResource->>CSVDownload: fetch CSV
CSVDownload-->>EnterpriseResource: CSV rows
EnterpriseResource->>ClassicPATModel: create assets from classic PAT rows
ClassicPATModel-->>EnterpriseResource: token nodes and graph edges
Merge Risk: 🔵 Low · up to Repeated GitHub rate limits can delay an enterprise collection before credential inventory is skipped. This is a bounded operational risk rather than a merge blocker. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 7.59% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 79 functions across 16 files. (12 skipped: 12 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
A rabbit checks the export trail, Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Organization GitHub App installations with
repository_selection: selectedpreviously had no repository access edges. This change queries the enterprise organization-installation repositories API and addsGH_CanAccessedges for granted repositories found in the collected repository inventory. Installations set toallkeep their existing behavior. Missing permission skips selected-repository edges, and a rate limit stops further selected-installation lookups for that collection.The collecting enterprise app needs
Enterprise organization installations: readorEnterprise organization installation repositories: read. The README andGH_AppInstallationdescription document the behavior and permission.Validation: 379 tests passed; Ruff passed. In a live collection, the selected installation gained the expected edge to its one granted repository (0 before, 1 after).
Depends on #80. Until BED-9987 merges, this PR's diff against
mainalso includes its classic PAT inventory commits. The BED-9989 change is commit7c45ad5.Summary by CodeRabbit